Skip to content

style: make TOC sticky#185

Closed
IgnaceMaes wants to merge 3 commits intoember-learn:mainfrom
IgnaceMaes:sticky-toc
Closed

style: make TOC sticky#185
IgnaceMaes wants to merge 3 commits intoember-learn:mainfrom
IgnaceMaes:sticky-toc

Conversation

@IgnaceMaes
Copy link
Copy Markdown
Member

@IgnaceMaes IgnaceMaes commented Feb 21, 2024

Builds upon #184 to make the TOC sticky.

Implements #182.

Can be tested on https://deploy-preview-185--guidemaker-ember-template.netlify.app/release/guide-test

@netlify
Copy link
Copy Markdown

netlify bot commented Feb 21, 2024

Deploy Preview for guidemaker-ember-template ready!

Name Link
🔨 Latest commit 0aa4d00
🔍 Latest deploy log https://app.netlify.com/sites/guidemaker-ember-template/deploys/65d78944a129cd0008b9fdfa
😎 Deploy Preview https://deploy-preview-185--guidemaker-ember-template.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@IgnaceMaes IgnaceMaes added the enhancement New feature or request label Feb 21, 2024
@IgnaceMaes IgnaceMaes marked this pull request as draft February 21, 2024 17:45
@IgnaceMaes IgnaceMaes marked this pull request as ready for review February 21, 2024 17:48
@IgnaceMaes
Copy link
Copy Markdown
Member Author

This breaks on mobile. Will take another look 👀

@IgnaceMaes IgnaceMaes marked this pull request as draft February 21, 2024 19:41
@IgnaceMaes IgnaceMaes marked this pull request as ready for review February 22, 2024 08:33
@IgnaceMaes
Copy link
Copy Markdown
Member Author

The learning team decided not to do this, so closing for now. We can revise later.

@IgnaceMaes IgnaceMaes closed this Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant