style: make on-this-page sticky#184
Merged
mansona merged 3 commits intoember-learn:mainfrom Feb 22, 2024
Merged
Conversation
✅ Deploy Preview for guidemaker-ember-template ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Closed
Member
|
This looks great! I think you need to just update tests since you added a new page 👍 |
Member
Author
|
Ah good catch, updated! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements part of #182
Makes the "On This Page" section sticky
Test: https://deploy-preview-184--guidemaker-ember-template.netlify.app/release/guide-test