Skip to content

feat: highlight active title in "On This Page"#186

Merged
mansona merged 7 commits intoember-learn:mainfrom
IgnaceMaes:highlight-active-title
Mar 11, 2024
Merged

feat: highlight active title in "On This Page"#186
mansona merged 7 commits intoember-learn:mainfrom
IgnaceMaes:highlight-active-title

Conversation

@IgnaceMaes
Copy link
Copy Markdown
Member

@IgnaceMaes IgnaceMaes commented Feb 21, 2024

Fixes #181

Builds on top of #184

image

@IgnaceMaes IgnaceMaes added the enhancement New feature or request label Feb 21, 2024
@netlify
Copy link
Copy Markdown

netlify bot commented Feb 21, 2024

Deploy Preview for guidemaker-ember-template ready!

Name Link
🔨 Latest commit 7cea871
🔍 Latest deploy log https://app.netlify.com/sites/guidemaker-ember-template/deploys/65ef2e0321e97b00087b8f12
😎 Deploy Preview https://deploy-preview-186--guidemaker-ember-template.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@IgnaceMaes IgnaceMaes marked this pull request as draft February 21, 2024 23:16
@IgnaceMaes IgnaceMaes marked this pull request as ready for review February 22, 2024 08:21
@mansona
Copy link
Copy Markdown
Member

mansona commented Feb 22, 2024

OMG I LOVE IT!

As this builds on the other PR I'm going to wait for that one before I merge 👍

@IgnaceMaes IgnaceMaes force-pushed the highlight-active-title branch from bfdf974 to 7582eb7 Compare February 22, 2024 17:47
Copy link
Copy Markdown
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

I'm going to merge this as an enhancement because #188 is going to drop support for Ember < 3.28 and we can keep the breaking change there

@mansona mansona merged commit a41f7d2 into ember-learn:main Mar 11, 2024
@mansona mansona mentioned this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Highlight current "on this page" title based on scroll position

2 participants