Skip to content

Convert to a V2 addon and drop support for Ember < 3.28#188

Merged
mansona merged 13 commits intomainfrom
v2
May 2, 2024
Merged

Convert to a V2 addon and drop support for Ember < 3.28#188
mansona merged 13 commits intomainfrom
v2

Conversation

@mansona
Copy link
Copy Markdown
Member

@mansona mansona commented Mar 9, 2024

Roughly speaking I ran ember init -b @embroider/addon-blueprint --pnpm to get this far, and then did some tweaking

Sure this is a little extreme but it's at least possible so we should consider it (maybe) 😂

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 9, 2024

Deploy Preview for guidemaker-ember-template ready!

Name Link
🔨 Latest commit 48a1c07
🔍 Latest deploy log https://app.netlify.com/sites/guidemaker-ember-template/deploys/6633ffbe0105f60008737b65
😎 Deploy Preview https://deploy-preview-188--guidemaker-ember-template.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mansona mansona force-pushed the v2 branch 5 times, most recently from 0c21f9a to ebc0d0d Compare April 4, 2024 16:10
@mansona mansona changed the title Convert to a V2 addon Convert to a V2 addon and drop support for Ember < 3.28 Apr 4, 2024
@mansona mansona force-pushed the v2 branch 2 times, most recently from 412ffd1 to eab7062 Compare April 4, 2024 16:16
Copy link
Copy Markdown
Member

@jaredgalanis jaredgalanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@IgnaceMaes
Copy link
Copy Markdown
Member

The callout images are not present, that seems unexpected?

https://deploy-preview-188--guidemaker-ember-template.netlify.app/release/examples/callouts

image

@IgnaceMaes
Copy link
Copy Markdown
Member

Images look all good now with the latest Embroider version!

Only thing missing seems to be the icons:

image

Copy link
Copy Markdown
Member

@IgnaceMaes IgnaceMaes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good now!

@ember-learn ember-learn deleted a comment from github-actions bot May 2, 2024
@mansona mansona merged commit 2317c71 into main May 2, 2024
@mansona mansona deleted the v2 branch May 2, 2024 21:08
This was referenced Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants