Open
Conversation
sbc100
approved these changes
Apr 17, 2026
sbc100
reviewed
Apr 17, 2026
| // Do not ask user consent to enable audio playback (0: Allow autoplay for all media) | ||
| user_pref("media.autoplay.default", 0); | ||
| // Enable JSPI support | ||
| user_pref("javascript.options.wasm_js_promise_integration", true); |
Collaborator
There was a problem hiding this comment.
I don't see this in the browser testing config? Are we not testing JSPI firefox today? Should we be? @brendandahl
Collaborator
There was a problem hiding this comment.
i.e. should we add this also to test/firefox_user.js?
Should we make a plan to merge these to two configs?
Collaborator
There was a problem hiding this comment.
Last I check it wasn't fully ready, but that's was several months ago. Maybe it's fine now?
sbc100
approved these changes
Apr 17, 2026
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Apr 17, 2026
sbc100
added a commit
that referenced
this pull request
Apr 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JSPI is not yet enabled by default in Firefox, so enable it to be able to use emrun to test JSPI compiled Emscripten pages.