Skip to content

Enable JSPI in Firefox in emrun. #26714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
juj wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −0
Open

Enable JSPI in Firefox in emrun. #26714

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions emrun.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,6 +317,8 @@ def create_emrun_safe_firefox_profile():
user_pref("javascript.options.wasm_memory64", true);
// Do not ask user consent to enable audio playback (0: Allow autoplay for all media)
user_pref("media.autoplay.default", 0);
// Enable JSPI support
user_pref("javascript.options.wasm_js_promise_integration", true);
Copy link
Copy Markdown
Collaborator

@sbc100 sbc100 Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see this in the browser testing config? Are we not testing JSPI firefox today? Should we be? @brendandahl

Copy link
Copy Markdown
Collaborator

@sbc100 sbc100 Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i.e. should we add this also to test/firefox_user.js?

Should we make a plan to merge these to two configs?

Copy link
Copy Markdown
Collaborator

@brendandahl brendandahl Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last I check it wasn't fully ready, but that's was several months ago. Maybe it's fine now?

''')
if emrun_options.private_browsing:
f.write('''
Expand Down
Loading