clean: remove redundant allImportedFiles check in _onwrite#346
Merged
ezolenko merged 1 commit intoezolenko:masterfrom Jun 7, 2022
Merged
Conversation
- this checks if any of the files in `parsedConfig.fileNames` are _not_ in `allImportedFiles`, but all the files in `parsedConfig.fileNames` are explicitly added in the `options` hook on line 98 - so this is redundant / dead code; the check will never be true - this can be considered a remnant of an old bug as an old commit fixed a bug with `allImportedFiles` after it was released: ezolenko@f24359e
agilgur5
added
the
kind: internal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove an old, redundant check against
allImportedFilesthat is actually dead codeDetails
this checks if any of the files in
parsedConfig.fileNamesare not inallImportedFiles, but all the files inparsedConfig.fileNamesare explicitly added in theoptionshook on line 98this can be considered a remnant of an old bug as an old commit fixed a bug with
allImportedFilesafter it was released: fix: don't skip emitting type declarations forincluded files #176