fix: filter "missed" declarations as well

[agilgur5]

Summary

Only output declarations for files that pass the filter check so there isn't a mismatch between JS being excluded, but DTS declarations still being output.

• Fixes exclude filters .js output, but not .d.ts (plugin exclude vs. tsconfig exclude) #225
• Fixes co-located test types included in dist (tsconfig exclude vs plugin exclude) #280
• Fixes the pattern of bugs causing confusion around plugin include / exclude vs. tsconfig include / exclude that I mentioned in fix(github): improve formatting of issue template spoilers #311 (comment)

Details

• these should run through the same filter as runs in transform etc
  • prior to this, the plugin exclude would filter files in transform, meaning no JS would be output for them, but would still output declarations for these very same files that no JS was produced for
    • (this would only happen if one were using an include glob or something that made the file appear twice, i.e. once by Rollup in transform and once in parsedConfig.fileNames)
  • this change makes it so the plugin exclude affects both JS and DTS output equivalently
    • it was very confusing when it didn't, and users relied on setting different tsconfig excludes to workaround this (as a tsconfig exclude would make the file not appear in parsedConfig.fileNames)

[agilgur5]

Huh, so I was looking into allImportedFiles because it causes #283 (see root cause analysis in #283 (comment)), and I found that the commit that adds it also removed the filter that was already there on this line of the diff.

So this PR undoes that line. And with #176 and #346, basically that entire commit is undone....

Considering #283 is caused by the follow-up commit, it seems like the entire allImportedFiles Set may in fact be erroneous and have caused several regressions... 😕

It seems to have been created for #162 and #136 (comment) :

• Plugin not respecting include / exclude when generating declarations #162 seems a bit suspect now, as the filter should have made sure that no JS files had declarations generated for them.
  • The version they were on has a filter there
  • OP also never responded there to the "fix"
  • It is possible that that was occurring due to a bug in pluginutils's createFilter implementation, that being said. But I'm not sure, that was an older version, just a possibility 🤷
• Declaration generated in wrong folder when using object as input (multi-entry) #136 (comment) is different, that's because this the current partial workaround for type-only files.
  • Fixing Declarations not generated for type-only files not explicitly specified in tsconfig #211 in its entirety may fix that issue as well, though so would using a tsconfigOverride with a different include or a tsconfig.build.json as a current workaround
    • ^That's actually the optimal solution that was stated in co-located test types included in dist (tsconfig exclude vs plugin exclude) #280 (which this PR fixed) as well

In any case, the main impact of allImportedFiles was undone in #176 anyway. So removing the resolution piece for #283 shouldn't have much impact, other than being a bugfix / regression fix.

[agilgur5]

Yeaaaa, did some more digging and per #283 (comment) , allImportedFiles from #162 seems to have been entirely erroneous and a source of at least 5 regressions in the past few years (some that were quite common).

The last two fixes for those regressions, this PR and #365, have yet to be released either, so like big OOF on how many regressions for how many years that's caused 😕 😕