Conversation
- updating dependencies
…ing bundler to node16
module: 'ES2022', update moduleResolution default to node16, add cts + `mts
module: 'ES2022', update moduleResolution default to node16, add cts + `mtsmodule: 'ES2022', update moduleResolution default to node16, add cts + mts
Collaborator
|
Replaced by #453 |
Collaborator
|
Or rather, this got split into multiple PRs it looks like:
Much nicer and easier to read as separate PRs! |
agilgur5
reviewed
Jun 30, 2023
module: 'ES2022', update moduleResolution default to node16, add cts + mtsmodule: 'ES2022', support moduleResolution overrides, support cts + mts
module: 'ES2022', support moduleResolution overrides, support cts + mtsmodule: 'ES2022', support newer moduleResolution kinds, support cts + mts
Owner
Author
|
Yeah, ignore that PR, I started too many changes at once and updated deps too far and that required yet more changes and so on (we'd still have to figure out ts-jest problems eventually I guess). All interesting changes are pulled out into those 3 PRs |
Collaborator
|
Ah right, EDIT: welp, that gives even more problems because some of the test code does not work in ESM mode (e.g. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix for #437
Details
moduleResolutionoption as is ("node", "node16", "nodenext")