support newer moduleResolution kinds, update build to TS 5.x

[ezolenko]

Summary

Fixes #437

Details

• keeping node* moduleResolution option as is ("node", "node16", "nodenext", "bundler")
• overriding "classic" and empty to Node10 (old behavior was overriding everything to Node10)

[agilgur5]

I'm gonna need to review this in a lot more detail (need to catch up on TS changes since 5.x hit GA and refresh myself on this codebase), but I mentioned mjs support and bundler in #434 (comment).

bundler actually seemed the most appropriate at the time (since Rollup is a bundler) for Node16+, particularly due to the file extension issues. That's actually why I didn't implement support for mjs / cjs earlier because the file extension requirement could break many things (that and no user requested it)

[ezolenko]

Yeah, this basically lowest effort to let users use more moduleResolution values without figuring out exactly what the differences are.

[agilgur5]

So I think bundler should not be overwritten either. With that change and README modifications about this, I think we could approve and merge this in.

Without tests though, we won't be able to confirm some of the behavior of node16 / nodeNext (particularly around file extensions) -- it is possible we may need to override those two to bundler as well

[agilgur5]

mostly LGTM now, just left a tiny comment style comment. we'll ofc iterate on the docs as we test more and get feedback

[ezolenko]

Well, shouldn't break anything. I'll release this sometime tomorrow.

[ezolenko]

In 0.36.0 now

[PetarKirov]

@ezolenko with 0.36.0 I'm getting the following error:

[!] (plugin rpt2) Error: Incompatible tsconfig option. Module resolves to 'Node16'. This is incompatible with Rollup, please use 'module: "ES2015"', 'module: "ES2020"', 'module: "ES2022"', or 'module: "ESNext"'.

With the following tsconfig settings:

{
  "compilerOptions": {
    "module": "Node16",
    "moduleResolution": "Node16",
    // ...
  }
}

And the following Rollup plugin config settings:

  const fileExtensions = ['.mjs', '.cjs', '.js', '.ts', '.json'];

  const plugins = [
    json(),
    commonjs(),

    peerDepsExternal({
      packageJsonPath: path.join(dir, 'package.json'),
    }),
    nodeResolve({
      extensions: fileExtensions,
      preferBuiltins: true,
      exportConditions: ['node'],
      mainFields: ['module', 'main'], // This instructs Rollup to prioritize ESM over CJS when resolving modules
      modulesOnly: true,
    }),
    typescript({
      check: true,
      tsconfig: path.join(dir, 'tsconfig.lib.json'),
      useTsconfigDeclarationDir: true,
    }),
    del({ targets: `${dir}/dist/*` }),
  ];

I'm using the package following versions:

• rollup: 3.29.4
• @rollup/plugin-node-resolve: 15.2.1
• rollup-plugin-typescript2: 0.36.0

As far as I can see, this comes from these lines:

https://github.com/ezolenko/rollup-plugin-typescript2/blob/0.36.0/src/parse-tsconfig.ts#L46-L48

[agilgur5]

@PetarKirov this PR only changed the moduleResolution options, not the module options.

There are potentially additional changes needed for the module options, but for the most part, we'd likely just be overriding it to ESNext or something. As Rollup requires ESM throughout, CJS output would be incompatible (TS can output CJS for module node16 and nodenext). So the error is more or less still accurate.

If you need node16 for other tooling, you can use tsconfigOverride to set esnext or es2020 for rpt2 specifically.

[raphael-theriault-swi]

This doesn't work with either node16 or nodenext since they require the module field to match