Use correct hook to prepare firedrake-check for editable installs#4289
Merged
connorjward merged 1 commit intoreleasefrom May 8, 2025
Merged
Use correct hook to prepare firedrake-check for editable installs#4289connorjward merged 1 commit intoreleasefrom
connorjward merged 1 commit intoreleasefrom
Conversation
JHopeCollins
approved these changes
May 8, 2025
Member
JHopeCollins
left a comment
JHopeCollins
left a comment
There was a problem hiding this comment.
Works for me.
Maybe we want a CI job that only runs on release branch that installs an editable firedrake and just runs firedrake-check.
Contributor
Author
Personally I'm not too fussed about testing this. Editable installs are primarily a developer feature. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
firedrake-checkfor editable installs.