Skip to content

setup.py: Add _copy_check_files logic to bdist_wheel#4299

Closed
qbisi wants to merge 1 commit intofiredrakeproject:masterfrom
qbisi:bdist
Closed

setup.py: Add _copy_check_files logic to bdist_wheel#4299
qbisi wants to merge 1 commit intofiredrakeproject:masterfrom
qbisi:bdist

Conversation

@qbisi
Copy link
Contributor

@qbisi qbisi commented May 10, 2025

Description

This fix firedrake-check when building a binary distribution in nixpkgs.

@connorjward
Copy link
Contributor

I'm happy to merge this but can this go into release not master? I had to make a very similar fix there just recently.

@qbisi
Copy link
Contributor Author

qbisi commented May 12, 2025

BTW, I guess the script firedrake-status does not make sense in both sdist and bdist release
The script will try to read git version of the src repo under src directory (which exisit only when installed via firedrake-install script).

Noted that the script firedrake-status is removed in master branch, may this change be merged into release branch?

@qbisi
Copy link
Contributor Author

qbisi commented May 12, 2025

I am goint to submit the first init python3Packages.firedrake commit to nixpkgs before the release of nixos 25.05.
Is there any plan for another post release update?

Or is it Okay to just remove the script firedrake-{check,status} in nixpkgs binary release.

NixOS/nixpkgs#406239

@connorjward
Copy link
Contributor

It's probably simplest to just remove firedrake-check and firedrake-status

@qbisi qbisi closed this May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants