Skip to content

sassの設定を変更し、本番でもimg-urlで正しいパスで書き出されるようにした#8943

Merged
machida merged 2 commits intomainfrom
people-image-bug
Jul 18, 2025
Merged

sassの設定を変更し、本番でもimg-urlで正しいパスで書き出されるようにした#8943
machida merged 2 commits intomainfrom
people-image-bug

Conversation

@machida
Copy link
Copy Markdown
Member

@machida machida commented Jul 17, 2025

Summary by CodeRabbit

  • 新機能

    • 画像ファイルへのパス指定が簡単になるエイリアス機能を追加しました。
  • 改善

    • Sassのimage-url()関数で画像パスの指定方法が統一され、より直感的に画像を利用できるようになりました。

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Jul 17, 2025

Walkthrough

Webpackの環境設定で新しいエイリアス「images」が「app/assets/images」に追加されました。また、Sassのカスタム関数image-url($path)が修正され、画像パスの先頭に「images/」が付加されるようになりました。

Changes

ファイル/パス 変更概要
config/webpack/environment.js Webpackのエイリアス「images」を追加し、Sass関数image-url($path)のパス解決方法を変更

Poem

画像の道しるべ、エイリアスでぴょん!
Sassもうれしい、パスがすぐ見つかるよ。
ひと跳ねすれば、imagesの森、
Webpackと仲良し、うさぎもにっこり。 🥕


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 82f7ee3 and 5bcf085.

📒 Files selected for processing (1)
  • config/webpack/environment.js (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • config/webpack/environment.js
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: build_and_test
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@machida machida self-assigned this Jul 17, 2025
@machida machida merged commit 8b187ea into main Jul 18, 2025
3 checks passed
@machida machida deleted the people-image-bug branch July 18, 2025 00:24
@github-actions github-actions bot mentioned this pull request Jul 18, 2025
87 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant