本番環境でのCSSからの画像のパスを修正

[machida]

Summary by CodeRabbit

• バグ修正

  • 画像のパス解決方法を改善し、背景画像が正しく表示されるようになりました。

• チョア

  • CSSアセットのパブリックパス設定を環境変数に基づいて調整しました。

[coderabbitai]

Walkthrough

この変更では、Sassファイル内の背景画像指定をimage-url()ヘルパー関数に置き換え、Webpackの出力public path設定を環境変数に応じて動的に変更しています。これにより、アセットのパス解決方法が改善されています。

Changes

ファイル/グループ	変更内容概要
app/javascript/stylesheets/lp/blocks/lp/_lp-top-cover.sass	背景画像指定をurl()からimage-url()ヘルパー関数に変更
config/webpack/environment.js	CSSアセット用のwebpack出力public pathを環境変数に基づき動的に設定

Possibly related PRs

• sassの設定を変更し、本番でもimg-urlで正しいパスで書き出されるようにした #8943: Sassのimage-url()ヘルパー利用とWebpack設定の修正に直接関連。
• sassから画像を使えるようにし、メインビジュアルの画像を更新した #8939: Webpackのsass-loaderでimage-url()関数を有効化し、画像のパス解決方法を調整。

Poem

画像の道を正しく導く、
Sassの魔法でうさぎも跳ねる。
Webpackの道標、public pathを変え、
本番も開発も迷わず進む。
ピョンと一跳び、
画像もコードも、
春風のように軽やかに！ 🐇

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 30e998b and 1d899de.

📒 Files selected for processing (2)

• app/javascript/stylesheets/lp/blocks/lp/_lp-top-cover.sass (1 hunks)
• config/webpack/environment.js (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

**/*.js

Instructions used from:

Sources:
⚙️ CodeRabbit Configuration File

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: build_and_test

🔇 Additional comments (2)

config/webpack/environment.js (1)

17-20: APP_HOST_NAME環境変数とHTTPS強制設定を確認しました

本番環境（config/environments/production.rb）ですでに以下の箇所でENV["APP_HOST_NAME"]が使用され、一貫してHTTPSが強制されていることを確認しました。
したがって、config/webpack/environment.jsでのpublicPath設定も他のアセットホスト設定と整合しており、追加対応は不要です。

• config/environments/production.rb

  • config.action_mailer.default_url_options = { host: ENV["APP_HOST_NAME"], protocol: "https" }
  • config.action_mailer.asset_host = "https://#{ENV["APP_HOST_NAME"]}"
  • config.action_controller.asset_host = "https://#{ENV["APP_HOST_NAME"]}"
  • config.hosts << ENV["APP_HOST_NAME"] if ENV["APP_HOST_NAME"]
  • Rails.application.routes.default_url_options[:host] = ENV["APP_HOST_NAME"]
  • Rails.application.routes.default_url_options[:protocol] = 'https'

• config/webpack/environment.js

  • environment.config.output.publicPath = process.env.NODE_ENV === 'production' ? \https://${process.env.APP_HOST_NAME}/packs/` : '/packs/'`

app/javascript/stylesheets/lp/blocks/lp/_lp-top-cover.sass (1)

2-2: ✅ url('~')パターンの検出結果: 対応不要

rgで調査したところ、他ファイルにurl('~…')パターンは見つからず、image-url()への置換は
app/javascript/stylesheets/lp/blocks/lp/_lp-top-cover.sass のみで完了しています。
この変更でアセットパス解決は統一され、本番環境の問題も解消されるため承認します。

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.