Skip to content

UIIN-3606: Add number generator to additional holdings call numbers#2987

Merged
elsenhans merged 2 commits intomasterfrom
UIIN-3606-add-number-generator-to-additional-holdings-call-numbers
Mar 19, 2026
Merged

UIIN-3606: Add number generator to additional holdings call numbers#2987
elsenhans merged 2 commits intomasterfrom
UIIN-3606-add-number-generator-to-additional-holdings-call-numbers

Conversation

@elsenhans
Copy link
Copy Markdown
Contributor

@elsenhans elsenhans commented Mar 13, 2026

https://folio-org.atlassian.net/browse/UIIN-3606

Purpose

As a librarian I would like to use the call number number generator for additional call numbers in holdings.

To use the number generator functionality for holdings call number in the section "Additional holdings call numbers" please include the button "Generate call number" underneath each call number field in every repeatable row (please see mock-up attached).

Please include it in these forms:

  • create,
  • edit and
  • duplicate

The button "Generate call number" has the same functionality as the button "Generate call number" already included underneath the call number field in the section "Primary holdings call number".

  • Display of the Modal "Generate call number" to search and select a sequence from the call number sequences defined in Settings > Service interaction > Number generator sequences > Inventory: Call number (inventory_callNumber) to generate and display the next number in the call number field of the row.
  • existing functionality for Number generator Options (Settings > Inventory > Holdings, Items > Number generator options > Holdings > Call number)
    • Off
    • On, field editable
    • On, field not editable

Approach

  • add NumberGeneratorModalButton under additional call number
  • just show NumberGeneratorModalButton if showNumberGenerator is true (settings Number generator options - Holdings - Call number are not Off)
  • disable additionalCallNumber fields if settings Number generator options - Holdings - Call number are On, field not editable

Additional:

  • change naming of ids: additem was misleading, that's why I removed it in the ids.
  • add test if "Generate call number" in additional call number section is visible and if additional call number field is disabled

Screenshots

image

Refs

Is connected to the issue for items: https://folio-org.atlassian.net/browse/UIIN-3608

@elsenhans elsenhans requested review from a team March 13, 2026 14:18
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 13, 2026

Jest Unit Test Results

    1 files  ±0    321 suites  ±0   10m 19s ⏱️ -2s
1 432 tests +1  1 413 ✅ +1  19 💤 ±0  0 ❌ ±0 
1 446 runs  +1  1 427 ✅ +1  19 💤 ±0  0 ❌ ±0 

Results for commit 0979d99. ± Comparison against base commit 45accaf.

♻️ This comment has been updated with latest results.

@sonarqubecloud
Copy link
Copy Markdown

<AdditionalCallNumbersFields callNumberTypeOptions={callNumberTypeOptions} isFieldBlocked={this.isFieldBlocked} onSwap={this.handleCallNumberSwap} />
<AdditionalCallNumbersFields
callNumberTypeOptions={callNumberTypeOptions}
isFieldBlocked={this.isFieldBlocked}
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like isFieldBlocked={this.isFieldBlocked} is not used at all.

@elsenhans elsenhans merged commit 670acea into master Mar 19, 2026
15 checks passed
@elsenhans elsenhans deleted the UIIN-3606-add-number-generator-to-additional-holdings-call-numbers branch March 19, 2026 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants