Skip to content

UIIN-3608: Add number generator to additional items call numbers#2988

Merged
elsenhans merged 4 commits intomasterfrom
UIIN-3608-add-number-generator-to-additional-items-call-numbers
Mar 19, 2026
Merged

UIIN-3608: Add number generator to additional items call numbers#2988
elsenhans merged 4 commits intomasterfrom
UIIN-3608-add-number-generator-to-additional-items-call-numbers

Conversation

@elsenhans
Copy link
Copy Markdown
Contributor

https://folio-org.atlassian.net/browse/UIIN-3608

Purpose

As a librarian I would like to use the call number number generator for additional items call numbers.

To use the number generator functionality for item call number in the section "Additional item call numbers" please include the button "Generate call number" underneath each call number field in every repeatable row (please see mock-ups attached).

Please include it in these forms:

  • create,
  • edit and
  • duplicate

The button "Generate call number" has the same functionality as the button "Generate call number" already included underneath the call number field in the section "Primary item call number".

  • Display of the Modal "Generate call number" to search and select a sequence from the call number sequences defined in Settings > Service interaction > Number generator sequences > Inventory: Call number (inventory_callNumber) to generate and display the next number in the call number field of the row.
  • existing functionality for Number generator Options (Settings > Inventory > Holdings, Items > Number generator options > Items > Call number)
    • Off
    • On, field editable
    • On, field not editable 

Exception

This is independent and separate from the functionality "Use the same generated number for accession number and call number" and button "Generate accession and call number"

Approach

This PR is based on #2987

  • add NumberGeneratorModalButton under additional call number
  • just show NumberGeneratorModalButton if showNumberGenerator is true (settings Number generator options - Items - Call number are not Off)
  • disable additionalCallNumber fields if settings Number generator options - Items - Call number are On, field not editable

Additional:

  • add test if "Generate call number" in additional call number section is visible and if additional call number field is disabled

Screenshots

image

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 18, 2026

Jest Unit Test Results

    1 files  ±0    321 suites  ±0   8m 31s ⏱️ -19s
1 433 tests +1  1 414 ✅ +1  19 💤 ±0  0 ❌ ±0 
1 447 runs  +1  1 428 ✅ +1  19 💤 ±0  0 ❌ ±0 

Results for commit ac9150e. ± Comparison against base commit 670acea.

♻️ This comment has been updated with latest results.

@elsenhans elsenhans requested a review from a team March 19, 2026 10:37
@sonarqubecloud
Copy link
Copy Markdown

@elsenhans elsenhans merged commit e3b68a9 into master Mar 19, 2026
15 checks passed
@elsenhans elsenhans deleted the UIIN-3608-add-number-generator-to-additional-items-call-numbers branch March 19, 2026 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants