Skip to content

fix: document naming rule not working for subscription invoices (backport #27386)#46148

Closed
mergify[bot] wants to merge 1 commit intoversion-13-hotfixfrom
mergify/bp/version-13-hotfix/pr-27386
Closed

fix: document naming rule not working for subscription invoices (backport #27386)#46148
mergify[bot] wants to merge 1 commit intoversion-13-hotfixfrom
mergify/bp/version-13-hotfix/pr-27386

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Feb 26, 2025

Document Naming Rule on Sales Invoice

CleanShot 2021-09-08 at 13 46 37@2x

Created a Subscription for the Company associated with that Company GSTIN

Now clicking on Fetch Subscription Updates on the Subscription document creates a Sales Invoice with default naming instead of following the Document Naming Rule.

This is because the Company GSTIN is set in the validate method of Sales Invoice while the naming is set before validate, hence while setting the name, the Company GSTIN condition is false


This is an automatic backport of pull request #27386 done by [Mergify](https://mergify.com).

(cherry picked from commit 9c27f9b)

# Conflicts:
#	erpnext/accounts/doctype/subscription/subscription.py
@mergify
Copy link
Contributor Author

mergify bot commented Feb 26, 2025

Cherry-pick of 9c27f9b has failed:

On branch mergify/bp/version-13-hotfix/pr-27386
Your branch is up to date with 'origin/version-13-hotfix'.

You are currently cherry-picking commit 9c27f9be1e.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   erpnext/accounts/doctype/subscription/subscription.py

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@ankush ankush closed this Feb 26, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants