Skip to content

fix: Presentation currency conversion in reports (backport #27316)#46166

Closed
mergify[bot] wants to merge 1 commit intoversion-13-hotfixfrom
mergify/bp/version-13-hotfix/pr-27316
Closed

fix: Presentation currency conversion in reports (backport #27316)#46166
mergify[bot] wants to merge 1 commit intoversion-13-hotfixfrom
mergify/bp/version-13-hotfix/pr-27316

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Feb 27, 2025

image

As shown in the image above there could be cases where a single GL might have both Debit and Credit values

Currently, the function used to convert values to presentation currency assumed that one GL Entry will either have debit or credit value while led to wrong values in the reports when a presentation currency was selected


This is an automatic backport of pull request #27316 done by [Mergify](https://mergify.com).

(cherry picked from commit ceaa804)

# Conflicts:
#	erpnext/accounts/report/utils.py
@mergify
Copy link
Contributor Author

mergify bot commented Feb 27, 2025

Cherry-pick of ceaa804 has failed:

On branch mergify/bp/version-13-hotfix/pr-27316
Your branch is up to date with 'origin/version-13-hotfix'.

You are currently cherry-picking commit ceaa804f04.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   erpnext/accounts/report/utils.py

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@ankush ankush closed this Feb 27, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants