Merged
Conversation
friedow
changed the title
Open
friedow
force-pushed
the
dependabot/cargo/iced-0.12.1
branch
from
4ceb3c5 to
700184d
Compare
Owner
Author
|
This is finally ready and the performance problems have been resolved thanks to #173! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After merging #81 I noticed a performance impact while filtering entries in release builds. This is why I reverted this change in #130.
Feature wise this PR works but I would rather stay on the older version if the new one decreases performance.