Merged
Conversation
a-kenji
approved these changes
Jul 28, 2024
Collaborator
a-kenji
left a comment
a-kenji
left a comment
There was a problem hiding this comment.
LGTM, tested. Seems to work well.
There is no scroll bar anymore, I guess that is intentional?
Owner
Author
|
Yep, scrollbar is not displayed intentionally. I think thats fine for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the iced scrollable widget renders all entries passed to it, we're experiencing degraded performance when plugins pass many entries to render. This is noticeable when using plugins like brave or firefox history with large history lists.
This PR removes the iced scrollable widget and instead creates a list of 10 enties which behave like a scrollable. This way we really only paint the 10 entries which are in the current viewport.
This fixes #157.