[ENH] Extend Mushroom body tutorials to use custom updates for resetting

[saadkhi]

closes #656

Description

• Replaced the Python reset_out_post and reset_neuron functions with GeNN custom updates in the Mushroom body tutorial.
• Ensured custom updates are added before building the model to avoid runtime errors, and created separate custom update models for neuron groups with different variable references.

[neworderofjamie]

This looks really great and works perfectly - well done for figuring this out! Two really minor things:

• Could you remove the unused duplicate custom updates you define in cell 13 (under the Simulate tutorial model section)
• There's no need to seperate the custom updates into two groups ("reset_neuron_group" and "reset_synapse_group")
• You can reduce the number of custom updates you have to create by resetting "out_post" in the same one as you reset other neuron variables (e.g. pn_kc's out_post could be reset using the same custom update as kc's neuron variables)

[saadkhi]

@neworderofjamie, I created a branch after forking the repository. Could this be the reason for the issue with continuous-integration/jenkins/branch? Please let me know how I can resolve it.

[neworderofjamie]

Don't worry about the continuous integration - it doesn't seem to be working for some reason but that's not related to you or your change. Could you implement at least the first two of my suggestions though? It's hard to tell with notebooks but it looks like your last change just deleted the plotting code

[saadkhi]

Could you implement at least the first two of my suggestions though? It's hard to tell with notebooks but it looks like your last change just deleted the plotting code

@neworderofjamie do i have make these this

`# Create custom updates
reset_neuron_pn = model.add_custom_update(
"reset_neuron_pn", "reset_neuron_group", reset_neuron_model,
var_refs={"V": create_var_ref(pn, "V"), "RefracTime": create_var_ref(pn, "RefracTime")}
)

reset_neuron_kc = model.add_custom_update(
"reset_neuron_kc", "reset_neuron_group", reset_neuron_model,
var_refs={"V": create_var_ref(kc, "V"), "RefracTime": create_var_ref(kc, "RefracTime")}
)

reset_neuron_ggn = model.add_custom_update(
"reset_neuron_ggn", "reset_neuron_group", reset_neuron_ggn_model,
var_refs={"V": create_var_ref(ggn, "V")}
)

reset_neuron_mbon = model.add_custom_update(
"reset_neuron_mbon", "reset_neuron_group", reset_neuron_model,
var_refs={"V": create_var_ref(mbon, "V"), "RefracTime": create_var_ref(mbon, "RefracTime")}
)

reset_synapse_pn_kc = model.add_custom_update(
"reset_synapse_pn_kc", "reset_synapse_group", reset_synapse_model,
var_refs={"out_post": create_out_post_var_ref(pn_kc)}
)

reset_synapse_ggn_kc = model.add_custom_update(
"reset_synapse_ggn_kc", "reset_synapse_group", reset_synapse_model,
var_refs={"out_post": create_out_post_var_ref(ggn_kc)}
)

reset_synapse_kc_mbon = model.add_custom_update(
"reset_synapse_kc_mbon", "reset_synapse_group", reset_synapse_model,
var_refs={"out_post": create_out_post_var_ref(kc_mbon)}
)`

in 1 group

[neworderofjamie]

I don't really understand your question. All I am saying is:

• There are two unused custom updates created in cell 13 - these should be removed
• You removed the plotting code in your last commit - this needs restoring
• There's no need to seperate the custom updates into two groups ("reset_neuron_group" and "reset_synapse_group") - put them all in "reset_group"

[saadkhi]

@neworderofjamie, I have completed the tasks you mentioned above.

[neworderofjamie]

Looks good, could you remove the duplicate calls to model.custom_update("reset_group") though

[saadkhi]

Looks good, could you remove the duplicate calls to model.custom_update("reset_group") though

@neworderofjamie , remove the duplicate calls to model.custom_update("reset_group")

[saadkhi]

@neworderofjamie I have fixed.

[neworderofjamie]

There is still a duplicate call to model.custom_update("reset_group") in the for s in range(4): plotting loop. Once this is removed, this PR is good to merge

[saadkhi]

model.custom_update("reset_group")
@neworderofjamie , I have changed

[neworderofjamie]

Very nice! thanks for your work on this

[saadkhi]

Very nice! thanks for your work on this

Thank you.