fix(grouping): Avoid mutating class-level initial_context in grouping info endpoint#109011
Closed
fix(grouping): Avoid mutating class-level initial_context in grouping info endpoint#109011
Conversation
…uping info endpoint The EventGroupingInfoEndpoint was mutating the class-level `initial_context` dict on StrategyConfiguration when setting `reverse_stacktraces`. Since `initial_context` is a class attribute (not instance), this mutation persisted across all subsequent uses of the same grouping config class, causing `reverse_when_serializing` to be set on stacktrace components and reversing frame order in grouping info snapshots. Fix: create an instance-level copy of `initial_context` before mutating it.
github-actions
bot
added
the
Scope: Backend
Member
Author
|
Closing as duplicate of #109009 which references all 9 issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #108923
Same root cause as #109009.
EventGroupingInfoEndpoint.get()mutates the class-levelinitial_contextdict onStrategyConfiguration, causingreverse_stacktracesto persist and reverse frame order in subsequent grouping info snapshot tests.initial_contextbefore mutating itTest plan
pytest tests/sentry/issues/endpoints/test_event_grouping_info.py::EventGroupingInfoEndpointTestCase::test_error_event_exception_order tests/sentry/grouping/test_grouping_info.py::test_grouping_info[newstyle:2026_01_20-javascript_xbrowser_edge]passes