Skip to content

fix(grouping): Avoid mutating class-level initial_context in grouping info endpoint #109011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joshuarli wants to merge 1 commit into from
Closed

fix(grouping): Avoid mutating class-level initial_context in grouping info endpoint #109011

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/sentry/issues/endpoints/event_grouping_info.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,12 @@ def get(self, request: HttpRequest, project, event_id) -> HttpResponse:
)
!= StacktraceOrder.MOST_RECENT_LAST
)
grouping_config.initial_context["reverse_stacktraces"] = should_reverse_stacktraces
# Create an instance-level copy so we don't mutate the class-level dict,
# which is shared across all instances of this config.
grouping_config.initial_context = {
**grouping_config.initial_context,
"reverse_stacktraces": should_reverse_stacktraces,
}

grouping_info = get_grouping_info(grouping_config, project, event)

Expand Down
Loading