feat(preprod): Add image comparison library with odiff batch support#109381
Merged
NicoHinderling merged 14 commits intomasterfrom Feb 26, 2026
Merged
feat(preprod): Add image comparison library with odiff batch support#109381NicoHinderling merged 14 commits intomasterfrom
NicoHinderling merged 14 commits intomasterfrom
Conversation
github-actions
bot
added
the
Scope: Backend
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
NicoHinderling
force-pushed
the
create-compare-task-v1-part2
branch
from
f4a0ef2 to
925d6b9
Compare
NicoHinderling
force-pushed
the
create-compare-task-v1-part1
branch
from
cfd6b61 to
4b1becf
Compare
This was referenced Feb 25, 2026
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
3 tasks
NicoHinderling
force-pushed
the
create-compare-task-v1-part2
branch
from
925d6b9 to
bbf23d9
Compare
NicoHinderling
force-pushed
the
create-compare-task-v1-part1
branch
from
10e12d3 to
5b2dabe
Compare
NicoHinderling
force-pushed
the
create-compare-task-v1-part1
branch
from
5b2dabe to
01b72d2
Compare
NicoHinderling
force-pushed
the
create-compare-task-v1-part2
branch
from
bbf23d9 to
8c12f49
Compare
Closed
NicoHinderling
force-pushed
the
create-compare-task-v1-part2
branch
from
8c12f49 to
bbba6eb
Compare
NicoHinderling
force-pushed
the
create-compare-task-v1-part2
branch
from
bbba6eb to
99c5a0b
Compare
NicoHinderling
force-pushed
the
create-compare-task-v1-part1
branch
from
ca48cee to
12f0802
Compare
NicoHinderling
force-pushed
the
create-compare-task-v1-part2
branch
from
99c5a0b to
6e0d8b2
Compare
NicoHinderling
force-pushed
the
create-compare-task-v1-part2
branch
from
6e0d8b2 to
b13b82d
Compare
NicoHinderling
force-pushed
the
create-compare-task-v1-part1
branch
from
12f0802 to
740cd3e
Compare
rbro112
reviewed
Feb 26, 2026
rbro112
approved these changes
Feb 26, 2026
NicoHinderling
force-pushed
the
create-compare-task-v1-part2
branch
from
0cf3c69 to
09b9a1a
Compare
Add compare_images and compare_images_batch functions that use the OdiffServer to produce diff masks with dual-threshold detection. Includes unit tests.
Move _to_pil_image calls inside try block so the finally cleanup handles the case where the second image conversion fails after the first succeeds. Co-Authored-By: Claude <noreply@anthropic.com>
…ror handling, naming, docs
NicoHinderling
force-pushed
the
create-compare-task-v1-part2
branch
from
09b9a1a to
5d1761a
Compare
NicoHinderling
added a commit
that referenced
this pull request
Feb 27, 2026
## Summary - Add `compare_snapshots` instrumented task that loads manifests from objectstore, diffs matched images in pixel-budget batches, uploads diff masks, and writes comparison results - State machine guards with atomic transitions (PENDING → PROCESSING → SUCCESS/FAILED) - Handles added/removed/unchanged/changed/skipped/errored image categories - Register task import in `server.py` **Stack**: 3/3 — depends on #109381
This was referenced Feb 27, 2026
rbro112
added a commit
that referenced
this pull request
Mar 5, 2026
Last week #109381 was merged which added the odiff binary to the backend CI workflow as it was a new required dependency for CI tests. Unfortunately, we missed adding this to the `backend-with-coverage` job which is used to upload selective testing coverage metrics. This caused all runs of backend with coverage to fail, resulting in no coverage data being uploaded. This fixes the `backend-with-coverage` workflow to install the odiff binary which should fix tests. Manual run to confirm this fixes: https://github.com/getsentry/sentry/actions/runs/22696037548
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
compare_imagesandcompare_images_batchfunctions using dual-threshold detection (base + color-sensitive)Stack: 2/3 — depends on #109380, next: Celery task