feat(preprod): Add snapshot comparison task by NicoHinderling · Pull Request #109382 · getsentry/sentry

NicoHinderling · 2026-02-25T21:55:03Z

Summary

Add compare_snapshots instrumented task that loads manifests from objectstore, diffs matched images in pixel-budget batches, uploads diff masks, and writes comparison results
State machine guards with atomic transitions (PENDING → PROCESSING → SUCCESS/FAILED)
Handles added/removed/unchanged/changed/skipped/errored image categories
Register task import in server.py

Stack: 3/3 — depends on #109381

src/sentry/preprod/snapshots/tasks.py

NicoHinderling · 2026-02-25T22:18:42Z

feat(preprod): Add snapshot image comparison task and endpoint logic #109151 : 2 dependent PRs (#109397 , #109546 )
feat(preprod): Add snapshot comparison task #109382 👈 (View in Graphite)
feat(preprod): Add image comparison library with odiff batch support #109381
feat(preprod): Add odiff server wrapper and Dockerfile binary install #109380
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

src/sentry/preprod/snapshots/tasks.py

rbro112 · 2026-02-26T22:28:31Z

src/sentry/preprod/snapshots/tasks.py

+
+logger = logging.getLogger(__name__)
+
+MAX_DIFF_PIXELS = 40_000_000


Where do these limits come from?

the same values used in the emerge code for now

MIght be good to document that

src/sentry/preprod/snapshots/tasks.py

rbro112 · 2026-02-26T22:31:46Z

src/sentry/preprod/snapshots/tasks.py

+        comparison.images_added = len(added)
+        comparison.images_removed = len(removed)
+        extras = comparison.extras or {}
+        extras["comparison_key"] = comparison_key


I'd be open to adding this as a col in the future

added an inline comment and linear ticket to track this

Add compare_snapshots task that loads manifests from objectstore, diffs matched images in pixel-budget batches via OdiffServer, uploads diff masks, and writes comparison results with state machine guards.

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

src/sentry/preprod/snapshots/tasks.py

src/sentry/preprod/api/models/snapshots/project_preprod_snapshot_models.py

NicoHinderling requested a review from a team as a code owner February 25, 2026 21:55

github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Feb 25, 2026

vercel bot deployed to Preview February 25, 2026 21:57 View deployment

cursor bot reviewed Feb 25, 2026

View reviewed changes

src/sentry/preprod/snapshots/tasks.py Outdated Show resolved Hide resolved

NicoHinderling force-pushed the create-compare-task-v1-part2 branch from f4a0ef2 to 925d6b9 Compare February 25, 2026 22:18

NicoHinderling force-pushed the create-compare-task-v1-part3 branch from d3c1b90 to 85baf2d Compare February 25, 2026 22:18

This was referenced Feb 25, 2026

feat(preprod): Add snapshot image comparison task and endpoint logic #109151

Merged

feat(preprod): Add odiff server wrapper and Dockerfile binary install #109380

Merged

NicoHinderling mentioned this pull request Feb 25, 2026

feat(preprod): Add image comparison library with odiff batch support #109381

Merged

vercel bot deployed to Preview February 25, 2026 22:21 View deployment

NicoHinderling mentioned this pull request Feb 25, 2026

feat(preprod): Add snapshot image comparison task with odiff #109150

Closed

3 tasks

cursor bot reviewed Feb 25, 2026

View reviewed changes

src/sentry/preprod/snapshots/tasks.py Show resolved Hide resolved

src/sentry/preprod/snapshots/tasks.py Show resolved Hide resolved

NicoHinderling force-pushed the create-compare-task-v1-part2 branch from 925d6b9 to bbf23d9 Compare February 25, 2026 23:12

NicoHinderling force-pushed the create-compare-task-v1-part3 branch from 85baf2d to cf39e6f Compare February 25, 2026 23:12

vercel bot deployed to Preview February 25, 2026 23:17 View deployment

NicoHinderling force-pushed the create-compare-task-v1-part3 branch from 5bc8093 to e05fbd9 Compare February 25, 2026 23:22

NicoHinderling force-pushed the create-compare-task-v1-part2 branch from bbf23d9 to 8c12f49 Compare February 25, 2026 23:22

NicoHinderling mentioned this pull request Feb 25, 2026

hodl #109397

Closed

vercel bot deployed to Preview February 25, 2026 23:25 View deployment

NicoHinderling force-pushed the create-compare-task-v1-part2 branch from 8c12f49 to bbba6eb Compare February 25, 2026 23:34

NicoHinderling force-pushed the create-compare-task-v1-part3 branch from e05fbd9 to d5d5560 Compare February 25, 2026 23:34

NicoHinderling mentioned this pull request Feb 25, 2026

feat(preprod): Add snapshot diff comparison UI #109403

Merged

vercel bot deployed to Preview February 25, 2026 23:38 View deployment

NicoHinderling force-pushed the create-compare-task-v1-part2 branch from bbba6eb to 99c5a0b Compare February 25, 2026 23:40

NicoHinderling force-pushed the create-compare-task-v1-part3 branch from d5d5560 to 1f0aee4 Compare February 25, 2026 23:40

vercel bot deployed to Preview February 25, 2026 23:43 View deployment

sentry bot reviewed Feb 25, 2026

View reviewed changes

src/sentry/preprod/snapshots/tasks.py Outdated Show resolved Hide resolved

NicoHinderling force-pushed the create-compare-task-v1-part3 branch from 1f0aee4 to 700c27e Compare February 25, 2026 23:52

NicoHinderling force-pushed the create-compare-task-v1-part2 branch from 99c5a0b to 6e0d8b2 Compare February 25, 2026 23:52

NicoHinderling force-pushed the create-compare-task-v1-part2 branch from 6e78d64 to a898675 Compare February 26, 2026 18:52

vercel bot deployed to Preview February 26, 2026 18:54 View deployment

NicoHinderling force-pushed the create-compare-task-v1-part3 branch from afa3fe6 to e6c85dd Compare February 26, 2026 19:27

NicoHinderling force-pushed the create-compare-task-v1-part2 branch from a898675 to 10c00d6 Compare February 26, 2026 19:27

vercel bot deployed to Preview February 26, 2026 19:30 View deployment

NicoHinderling force-pushed the create-compare-task-v1-part3 branch from e6c85dd to 43dd7c4 Compare February 26, 2026 20:56

NicoHinderling force-pushed the create-compare-task-v1-part2 branch from 10c00d6 to 4fe9275 Compare February 26, 2026 20:56

vercel bot deployed to Preview February 26, 2026 20:59 View deployment

NicoHinderling force-pushed the create-compare-task-v1-part2 branch from 4fe9275 to 8e0de3f Compare February 26, 2026 21:08

NicoHinderling force-pushed the create-compare-task-v1-part3 branch from 43dd7c4 to 6ec6bde Compare February 26, 2026 21:08

vercel bot deployed to Preview February 26, 2026 21:11 View deployment

NicoHinderling force-pushed the create-compare-task-v1-part3 branch from 6ec6bde to e1a67cb Compare February 26, 2026 22:06

rbro112 reviewed Feb 26, 2026

View reviewed changes

src/sentry/preprod/snapshots/tasks.py Outdated Show resolved Hide resolved

rbro112 reviewed Feb 26, 2026

View reviewed changes

src/sentry/preprod/snapshots/tasks.py Outdated Show resolved Hide resolved

rbro112 reviewed Feb 26, 2026

View reviewed changes

src/sentry/preprod/snapshots/tasks.py Show resolved Hide resolved

rbro112 reviewed Feb 26, 2026

View reviewed changes

src/sentry/preprod/snapshots/tasks.py Outdated Show resolved Hide resolved

rbro112 reviewed Feb 26, 2026

View reviewed changes

src/sentry/preprod/snapshots/tasks.py Outdated Show resolved Hide resolved

rbro112 reviewed Feb 26, 2026

View reviewed changes

NicoHinderling added 2 commits February 26, 2026 15:27

feat(preprod): Add snapshot comparison Celery task

309803f

Add compare_snapshots task that loads manifests from objectstore, diffs matched images in pixel-budget batches via OdiffServer, uploads diff masks, and writes comparison results with state machine guards.

bot feedback from 109151

55de3b6

cursor bot reviewed Feb 26, 2026

View reviewed changes

src/sentry/preprod/snapshots/tasks.py Outdated Show resolved Hide resolved

sure, very minor bot request..

592ed59

rbro112 reviewed Feb 27, 2026

View reviewed changes

src/sentry/preprod/api/models/snapshots/project_preprod_snapshot_models.py Outdated Show resolved Hide resolved

rbro112 approved these changes Feb 27, 2026

View reviewed changes

feedback

53fc4c4

This was referenced Feb 27, 2026

feat(preprod): Create admin gated recompare snapshots endpoint #109546

Merged

feat(preprod): Make snapshots endpoint org scoped #109575

Merged

feat(preprod): Add comparisonRunInfo data to response + new extra frontend models #109619

Merged

sentry-release-bot bot mentioned this pull request Mar 15, 2026

publish: getsentry/sentry@26.3.0 getsentry/publish#7450

Closed

3 tasks


		logger = logging.getLogger(__name__)

		MAX_DIFF_PIXELS = 40_000_000

Uh oh!

Conversation

NicoHinderling commented Feb 25, 2026

Summary

Uh oh!

Uh oh!

NicoHinderling commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rbro112 Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

NicoHinderling Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

rbro112 Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rbro112 Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

NicoHinderling Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

NicoHinderling commented Feb 25, 2026 •

edited

Loading