ref(performance): replace browserHistory with useNavigate in traceWaterfall

[evanpurkhiser]

No description provided.

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix prepared a fix for the issue found in the latest run.

• ✅ Fixed: Missing preventScrollReset causes unwanted scroll on navigation
  • Added preventScrollReset: true to the navigate options at line 294 to prevent unwanted scroll jumps during waterfall row focus changes, matching the behavior of the old browserHistory.replace shim.

Or push these changes by commenting:

@cursor push fd99f9649d

Preview (fd99f9649d)

diff --git a/static/app/views/performance/newTraceDetails/traceWaterfall.tsx b/static/app/views/performance/newTraceDetails/traceWaterfall.tsx
--- a/static/app/views/performance/newTraceDetails/traceWaterfall.tsx
+++ b/static/app/views/performance/newTraceDetails/traceWaterfall.tsx
@@ -291,7 +291,7 @@
                 node: nextNodePath,
               },
             },
-            {replace: true}
+            {replace: true, preventScrollReset: true}
           );
           queryStringAnimationTimeoutRef.current = null;
         }, debounce);

_{This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.}

[cursor]

Missing preventScrollReset causes unwanted scroll on navigation

Medium Severity

The old browserHistory.replace shim automatically included preventScrollReset: true to replicate react-router 3 behavior (as explicitly commented in browserHistory.tsx). The new navigate call only passes {replace: true}, losing the scroll reset prevention. This can cause the page to scroll unexpectedly when the query string is updated during waterfall row focus changes. The NavigateOptions type already supports preventScrollReset, so it just needs to be added alongside replace.