Skip to content

ref(nav): rename Nav to Navigation in navigation directory#110359

Merged
JonasBa merged 17 commits intomasterfrom
jb/ref/navigation/naming-nav
Mar 11, 2026
Merged

ref(nav): rename Nav to Navigation in navigation directory#110359
JonasBa merged 17 commits intomasterfrom
jb/ref/navigation/naming-nav

Conversation

@JonasBa
Copy link
Member

@JonasBa JonasBa commented Mar 10, 2026

The nav was using a mix of abbreviated Nav and Navigation terminology - this PR renames all instances to Navigation wording.

JonasBa and others added 5 commits March 10, 2026 11:53
Renames all abbreviated Nav identifiers and file names inside
static/app/views/navigation to use the full Navigation spelling,
respecting original casing:
- PascalCase: NavGroup to NavigationGroup, SecondaryNav to SecondaryNavigation
- camelCase: navGroup to navigationGroup, useCollapsedNav to useCollapsedNavigation
- SCREAMING_SNAKE_CASE: NAV_HEIGHT to NAVIGATION_HEIGHT

Also renames 22 files and updates all import paths in files both
inside and outside the navigation directory.

Co-Authored-By: Claude <noreply@anthropic.com>
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 10, 2026
Update all consumer files to use renamed navigation exports:
- NAV_SIDEBAR_SECONDARY_WIDTH_LOCAL_STORAGE_KEY → NAVIGATION_SIDEBAR_SECONDARY_WIDTH_LOCAL_STORAGE_KEY
- NAV_MOBILE_TOPBAR_HEIGHT → NAVIGATION_MOBILE_TOPBAR_HEIGHT
- PrimaryNavGroup → PrimaryNavigationGroup
- NavLayout → NavigationLayout
- SecondaryNav → SecondaryNavigation
- PRIMARY_NAV_GROUP_CONFIG → PRIMARY_NAVIGATION_GROUP_CONFIG
- navParentRef → navigationParentRef
- useIsNavTourActive → useIsNavigationTourActive
- Fix useNavigationigate typo → useNavigate

Co-Authored-By: Claude Sonnet 4.6 <noreply@example.com>
@JonasBa JonasBa marked this pull request as ready for review March 10, 2026 21:45
@JonasBa JonasBa requested review from a team as code owners March 10, 2026 21:45
@JonasBa JonasBa force-pushed the jb/ref/navigation/naming-nav branch from e8ca854 to c9eb3bf Compare March 10, 2026 22:07
JonasBa added 3 commits March 11, 2026 08:30
Address the todo comment in admin nav and move the nav definition inside
the nav file
Moves ProjectIcon inside Secondary Nav components, moves prop
definitions next to component implementations and moves isLinkActive
inside the primary nav component.
Reducing the nav footprint and inlining `useCommandPalette` inside the
nav
Base automatically changed from jb/ref/cleanup-secondary-sidebar to master March 11, 2026 15:37
Remove stacked nav wording, rename tour to navigationTour and move the
two primary nav components inside the primary folder

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Jonas <JonasBa@users.noreply.github.com>
Copy link
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

@JonasBa JonasBa merged commit dd8a259 into master Mar 11, 2026
63 checks passed
@JonasBa JonasBa deleted the jb/ref/navigation/naming-nav branch March 11, 2026 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants