fix(performance): Hide Tags tab in EAP transaction summary#110709
Merged
fix(performance): Hide Tags tab in EAP transaction summary#110709
Conversation
…abled The Tags tab in the non-domain-view path is not relevant when the performance-transaction-summary-eap feature flag is enabled. Hide it using the TabList.Item hidden prop and add tests for the behavior. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Member
Author
|
@sentry review |
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Tags tab not hidden in domain view EAP path
- Added hidden={isEAP} prop to the Tags TabList.Item in the tabList variable used for domain views to match the inline TabList rendering.
Or push these changes by commenting:
@cursor push 58f3557336
Preview (58f3557336)
diff --git a/static/app/views/performance/transactionSummary/header.tsx b/static/app/views/performance/transactionSummary/header.tsx
--- a/static/app/views/performance/transactionSummary/header.tsx
+++ b/static/app/views/performance/transactionSummary/header.tsx
@@ -160,7 +160,9 @@
>
<TabList.Item key={Tab.TRANSACTION_SUMMARY}>{t('Overview')}</TabList.Item>
<TabList.Item key={Tab.EVENTS}>{t('Sampled Events')}</TabList.Item>
- <TabList.Item key={Tab.TAGS}>{t('Tags')}</TabList.Item>
+ <TabList.Item key={Tab.TAGS} hidden={isEAP}>
+ {t('Tags')}
+ </TabList.Item>
<TabList.Item key={Tab.REPLAYS} textValue={t('Replays')} hidden={!hasSessionReplay}>
{t('Replays')}
<ReplayCountBadge count={replaysCount} />This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.
Member
Author
Add hidden={isEAP} prop to Tags TabList.Item in the tabList variable
used by domain views (frontend/backend/mobile). This matches the fix
already applied to the inline TabList rendering.
Applied via @cursor push command
nsdeschenes
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't support the Tags tab in EAP yet. Hide it for now.