Skip to content

fix(performance): Hide Tags tab in EAP transaction summary #110709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mjq merged 2 commits into from
Mar 16, 2026
+49 −2
Merged

fix(performance): Hide Tags tab in EAP transaction summary #110709

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
488267e
fix(performance): Hide Tags tab in transaction summary when EAP is en…
mjq Mar 14, 2026
308f3ef
fix(performance): Hide Tags tab for EAP users in domain view
cursoragent Mar 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 40 additions & 0 deletions static/app/views/performance/transactionSummary/header.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,4 +79,44 @@ describe('Performance > Transaction Summary Header', () => {

expect(await screen.findByRole('tab', {name: 'Overview'})).toBeInTheDocument();
});

it('should show Tags tab by default', async () => {
const {project, organization, router, eventView} = initializeData();

render(
<TransactionHeader
eventView={eventView}
location={router.location}
organization={organization}
projects={[project]}
projectId={project.id}
transactionName="transaction_name"
currentTab={Tab.TRANSACTION_SUMMARY}
/>
);

expect(await screen.findByRole('tab', {name: 'Tags'})).toBeInTheDocument();
});

it('should hide Tags tab when EAP feature is enabled', async () => {
const {project, organization, router, eventView} = initializeData({
features: ['performance-transaction-summary-eap'],
});

render(
<TransactionHeader
eventView={eventView}
location={router.location}
organization={organization}
projects={[project]}
projectId={project.id}
transactionName="transaction_name"
currentTab={Tab.TRANSACTION_SUMMARY}
/>,
{organization}
);

await screen.findByRole('tab', {name: 'Overview'});
expect(screen.queryByRole('tab', {name: 'Tags'})).not.toBeInTheDocument();
});
});
11 changes: 9 additions & 2 deletions static/app/views/performance/transactionSummary/header.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ import {MobileHeader} from 'sentry/views/insights/pages/mobile/mobilePageHeader'
import {MOBILE_LANDING_SUB_PATH} from 'sentry/views/insights/pages/mobile/settings';
import {useDomainViewFilters} from 'sentry/views/insights/pages/useFilters';
import Breadcrumb, {getTabCrumbs} from 'sentry/views/performance/breadcrumb';
import {useTransactionSummaryEAP} from 'sentry/views/performance/eap/useTransactionSummaryEAP';
import {TAB_ANALYTICS} from 'sentry/views/performance/transactionSummary/pageLayout';
import {eventsRouteWithQuery} from 'sentry/views/performance/transactionSummary/transactionEvents/utils';
import {profilesRouteWithQuery} from 'sentry/views/performance/transactionSummary/transactionProfiles/utils';
Expand Down Expand Up @@ -125,6 +126,8 @@ export function TransactionHeader({
[getNewRoute, organization, location, projects, currentTab, navigate]
);

const isEAP = useTransactionSummaryEAP();

function handleCreateAlertSuccess() {
trackAnalytics('performance_views.summary.create_alert_clicked', {
organization,
Expand Down Expand Up @@ -157,7 +160,9 @@ export function TransactionHeader({
>
<TabList.Item key={Tab.TRANSACTION_SUMMARY}>{t('Overview')}</TabList.Item>
<TabList.Item key={Tab.EVENTS}>{t('Sampled Events')}</TabList.Item>
<TabList.Item key={Tab.TAGS}>{t('Tags')}</TabList.Item>
<TabList.Item key={Tab.TAGS} hidden={isEAP}>
{t('Tags')}
</TabList.Item>
<TabList.Item key={Tab.REPLAYS} textValue={t('Replays')} hidden={!hasSessionReplay}>
{t('Replays')}
<ReplayCountBadge count={replaysCount} />
Expand Down Expand Up @@ -319,7 +324,9 @@ export function TransactionHeader({
>
<TabList.Item key={Tab.TRANSACTION_SUMMARY}>{t('Overview')}</TabList.Item>
<TabList.Item key={Tab.EVENTS}>{t('Sampled Events')}</TabList.Item>
<TabList.Item key={Tab.TAGS}>{t('Tags')}</TabList.Item>
<TabList.Item key={Tab.TAGS} hidden={isEAP}>
{t('Tags')}
</TabList.Item>
<TabList.Item
key={Tab.REPLAYS}
textValue={t('Replays')}
Expand Down
Loading