Skip to content

Conversation

@imjohnbo
Copy link
Contributor

Summary

👋 🦄 🐳 Hello! This pull request adds support for converting multiple links from an HTML copy source into a comment box upon paste. Previous copy/paste functionality is unchanged, e.g. when pasting a plaintext link onto a selection.

See GIF and internal tracking issue for more context 🍿 📺:
paste-public

@imjohnbo imjohnbo requested a review from a team as a code owner January 25, 2022 17:42
@imjohnbo imjohnbo requested a review from dgreif January 25, 2022 17:42
Copy link
Contributor

@koddsson koddsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me! I pushed some commits rather than making review comments. I hope that's OK. Let me know what you think of those changes, and if that's good, I can merge this and make a new release for you.

@imjohnbo
Copy link
Contributor Author

These changes look good to me! I pushed some commits rather than making review comments. I hope that's OK. Let me know what you think of those changes, and if that's good, I can merge this and make a new release for you.

Woohoo! Your additional changes look wonderful to me ✨ except for one comment. TIL about dom.iterable to avoid Array.froming, and I do like the idea to push and then join an array rather than concatenate a string. Thanks for the quick review!

@koddsson koddsson merged commit ae282ef into github:main Jan 26, 2022
@imjohnbo imjohnbo deleted the imjohnbo/markdown-links branch January 26, 2022 15:10
imjohnbo added a commit to imjohnbo/paste-markdown that referenced this pull request Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants