Fix Microsoft Edge link paste #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theinterned
approved these changes
Jan 28, 2022
Contributor
Author
|
I moved to Draft because I'd like to test another edge case before proceeding. :-) |
fix: only markdownify if corresponding plaintext can be found
Contributor
Author
|
Sorry for the back and forth – this is now ready for re-review 🙏! Originally, I was checking for a certain content-type and returning quickly if it was detected. However, I think the better solution to the problem is to add proper error checking to the Let me know if you have any questions 🙇. |
theinterned
approved these changes
Feb 1, 2022
Contributor
theinterned
left a comment
theinterned
left a comment
There was a problem hiding this comment.
This does seem more straightforward! Nice!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Hello! After #35, I discovered that this feature does not work on Microsoft Edge due to Improved copy and paste of URLs in Microsoft Edge. This pull request brings the functionality of #35 to Microsoft Edge.
Full support for Improved copy and paste of URLs in Microsoft Edge would come in a subsequent PR.
Here is a before/after:
Thanks for taking a look!