Notifications pagination sometimes renders incorrect `div-only` links

[silverwind]

Description

I noticed a bug on the /notifications page in 1.25 where it sometimes renders incorrect div-only links, that when clicked will result in navigation to unstyled pages. HTML of the incorrect pagination:

<div class="center page buttons">
  <div class="ui borderless pagination menu">
    <a class=" item navigation" href="/notifications?div-only=true&amp;sequence-number=2">
    </a>
    <a class=" item navigation" href="/notifications?page=1&amp;div-only=true&amp;sequence-number=2">
    </a>
    <a class="item" href="/notifications?page=1&amp;div-only=true&amp;sequence-number=2">1</a>
    <a class="active item">2</a>
    <a class="disabled item navigation">
      <span class="navigation_label">Next</span>
    </a>
    <a class="disabled item navigation">
      <span class="navigation_label">Last</span>
    </a>
  </div>
</div>

I don't know how to reliably reproduce this yet, it does not happen all the time.

Gitea Version

2c778ff

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

Git Version

No response

Operating System

No response

How are you running Gitea?

self-compiled

Database

MySQL/MariaDB

[wxiaoguang]

The fix can be like this: remove "div-only" from the parameters.

[silverwind]

I think div-only should at least never be rendered into HTML templates. As far as I see, this parameter is only used when JS fetches partial HTML.

[wxiaoguang]

yes, so it should be removed before rendering the tmpl page.

[wxiaoguang]

-> Fix notifications pagination query parameters #36351