Skip to content

Comments

Fix notifications pagination query parameters#36351

Merged
lunny merged 3 commits intogo-gitea:mainfrom
wxiaoguang:fix-pager
Jan 12, 2026
Merged

Fix notifications pagination query parameters#36351
lunny merged 3 commits intogo-gitea:mainfrom
wxiaoguang:fix-pager

Conversation

@wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Jan 12, 2026

Fix #36350

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 12, 2026
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Jan 12, 2026
@wxiaoguang wxiaoguang added this to the 1.26.0 milestone Jan 12, 2026
@wxiaoguang wxiaoguang mentioned this pull request Jan 12, 2026
Closed
@silverwind
Copy link
Member

silverwind commented Jan 12, 2026

I think sequence-number likely also should be removed, seeing that it's only used in conjunction with div-only when JS loads the content.

@wxiaoguang
Copy link
Contributor Author

wxiaoguang commented Jan 12, 2026

I think sequence-number likely also should be removed, seeing that it's only used in conjunction with div-only when JS loads the content.

I have removed, you can read the code.

@silverwind
Copy link
Member

silverwind commented Jan 12, 2026 •
edited
Loading

Found a reproduction on main branch:

  • In tab 1, open the notifications list with pagination visible
  • In container tab 2, log in another user account, generate notifications
  • Pagination in tab 1 will reload via SSE after a few seconds and show the unexpected query params

Now I will test with this branch.

silverwind
silverwind approved these changes Jan 12, 2026
View reviewed changes
Copy link
Member

@silverwind silverwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm this fixes the issue.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 12, 2026
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 12, 2026
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jan 12, 2026
@lunny lunny enabled auto-merge (squash) January 12, 2026 21:48
@lunny lunny merged commit 7a23e24 into go-gitea:main Jan 12, 2026
24 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jan 12, 2026
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Jan 12, 2026
@wxiaoguang @GiteaBot
Fix notifications pagination query parameters (go-gitea#36351)
d72bc38 
Fix go-gitea#36350
@GiteaBot GiteaBot mentioned this pull request Jan 12, 2026
Merged
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Jan 12, 2026
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jan 13, 2026
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
04a5ff7 
* giteaofficial/main:
  fill missing `has_code` in repository api (go-gitea#36338)
  Fix notifications pagination query parameters (go-gitea#36351)
  Fix cancel auto merge bug (go-gitea#36341)
  Bump appleboy/git-push-action from 1.0.0 to 1.2.0 (go-gitea#36306)
  Improve diff file headers (go-gitea#36215)
  Fix delete attachment check (go-gitea#36320)
  [skip ci] Updated translations via Crowdin
  LFS locks must belong to the intended repo (go-gitea#36344)
  Update chroma to v2.22.0 (go-gitea#36342)
  Update goldmark to v1.7.16 (go-gitea#36343)
  Fix some trivial problems (go-gitea#36336)
  Fix diff view style handling (go-gitea#36324)
  Refactor cat-file batch operations and support `--batch-command` approach (go-gitea#35775)
  Fix file-tree ui error when adding files to repo without commits (go-gitea#36312)
@wxiaoguang wxiaoguang deleted the fix-pager branch January 13, 2026 02:29
lunny pushed a commit that referenced this pull request Jan 13, 2026
@GiteaBot @wxiaoguang
Fix notifications pagination query parameters (#36351) (#36358)
d96b68c 
Backport #36351 by @wxiaoguang

Fix #36350

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lunny lunny lunny approved these changes

@silverwind silverwind silverwind approved these changes

Assignees

No one assigned

Labels

backport/done All backports for this PR have been created backport/v1.25 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code type/bug

Projects

None yet

Milestone

1.26.0

Development

Successfully merging this pull request may close these issues.

Notifications pagination sometimes renders incorrect div-only links

4 participants

@wxiaoguang @silverwind @lunny @GiteaBot