Skip to content

Comments

Mock external service in hcaptcha TestCaptcha#35604

Merged
techknowlogick merged 5 commits intogo-gitea:mainfrom
silverwind:fix-test-dep
Oct 10, 2025
Merged

Mock external service in hcaptcha TestCaptcha#35604
techknowlogick merged 5 commits intogo-gitea:mainfrom
silverwind:fix-test-dep

Conversation

@silverwind
Copy link
Member

@silverwind silverwind commented Oct 8, 2025

The test calls out to a web service which may be down or unreachable as seen in the linked issue. It's better for tests to not have such external dependencies to make them absolutely stable.

Fixes: #35571

The test calls out to a web service which may not be reachable or down
as seen in the linked issue. It's better for tests to not have such
external dependencies.

Fixes: go-gitea#35571
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 8, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Oct 8, 2025
@silverwind silverwind changed the title Remove external service dependency in hcaptcha TestCaptcha Mock external service in hcaptcha TestCaptcha Oct 8, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 8, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 10, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 10, 2025
@techknowlogick techknowlogick added backport/v1.24 This PR should be backported to Gitea 1.24 backport/v1.25 labels Oct 10, 2025
@techknowlogick techknowlogick merged commit 165a3ea into go-gitea:main Oct 10, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.26.0 milestone Oct 10, 2025
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Oct 10, 2025
The test calls out to a web service which may be down or unreachable as
seen in the linked issue. It's better for tests to not have such
external dependencies to make them absolutely stable.

Fixes: go-gitea#35571
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 10, 2025
techknowlogick pushed a commit that referenced this pull request Oct 10, 2025
Backport #35604 by silverwind

The test calls out to a web service which may be down or unreachable as
seen in the linked issue. It's better for tests to not have such
external dependencies to make them absolutely stable.

Fixes: #35571

Co-authored-by: silverwind <me@silverwind.io>
@silverwind silverwind deleted the fix-test-dep branch October 10, 2025 08:00
zjjhot added a commit to zjjhot/gitea that referenced this pull request Oct 13, 2025
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Update JS deps, misc tweaks (go-gitea#35643)
  Bump actions/checkout to v5 (go-gitea#35644)
  nix flake update (go-gitea#35639)
  Cleanup ActionRun creation (go-gitea#35624)
  bump archives&rar dep (go-gitea#35637)
  Fix merge panic (go-gitea#35606)
  Bump happy-dom from 19.0.2 to 20.0.0 (go-gitea#35625)
  Refactor ActionRunJob parsing into a reusable function (go-gitea#35623)
  Fix code tag style problem and LFS view bug (go-gitea#35628)
  Support Actions `concurrency` syntax (go-gitea#32751)
  The status icon of the Action step is consistent with GitHub (go-gitea#35618)
  Mock external service in hcaptcha TestCaptcha (go-gitea#35604)
  Fix inputing review comment will remove reviewer (go-gitea#35591)
  [skip ci] Updated translations via Crowdin
  Fix diffpatch API endpoint (go-gitea#35610)
  Print PR-Title into tooltip for actions (go-gitea#35579)
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Oct 14, 2025
The test calls out to a web service which may be down or unreachable as
seen in the linked issue. It's better for tests to not have such
external dependencies to make them absolutely stable.

Fixes: go-gitea#35571
@lunny lunny added the backport/done All backports for this PR have been created label Oct 15, 2025
lunny added a commit that referenced this pull request Oct 15, 2025
Backport #35604 by @silverwind

The test calls out to a web service which may be down or unreachable as
seen in the linked issue. It's better for tests to not have such
external dependencies to make them absolutely stable.

Fixes: #35571

Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@xnox xnox mentioned this pull request Dec 7, 2025
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jan 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport/done All backports for this PR have been created backport/v1.24 This PR should be backported to Gitea 1.24 backport/v1.25 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code type/testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flaky test: TestCaptcha

5 participants