Mock external service in hcaptcha TestCaptcha (#35604)#35663
Merged
lunny merged 4 commits intogo-gitea:release/v1.24from Oct 15, 2025
Merged
Mock external service in hcaptcha TestCaptcha (#35604)#35663lunny merged 4 commits intogo-gitea:release/v1.24from
lunny merged 4 commits intogo-gitea:release/v1.24from
Conversation
The test calls out to a web service which may be down or unreachable as seen in the linked issue. It's better for tests to not have such external dependencies to make them absolutely stable. Fixes: go-gitea#35571
GiteaBot
added
the
lgtm/need 2
lunny
approved these changes
Oct 14, 2025
GiteaBot
added
lgtm/need 1
silverwind
approved these changes
Oct 15, 2025
GiteaBot
added
lgtm/done
Member
|
Need to wait on test fix discussed in #35656 because golang has backported golang/go#75678 into 1.24 as well. |
silverwind
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #35604 by @silverwind
The test calls out to a web service which may be down or unreachable as seen in the linked issue. It's better for tests to not have such external dependencies to make them absolutely stable.
Fixes: #35571