fix: merge duplicate imports in sdk and test-utils packages (1/4)#19777
Conversation
Consolidate duplicate import statements from the same modules to comply with the import/no-duplicates ESLint rule. Changes: - packages/sdk: Merged duplicate imports from 'node:path' and '@google/gemini-cli-core' - packages/test-utils: Merged duplicate imports from 'node:fs' This is part 1 of 4 PRs to clean up import/no-duplicates warnings across the codebase (5 files in sdk + test-utils packages).
Summary of ChangesHello @Nixxx19, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on code quality and maintainability by consolidating duplicate import statements across several files in the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request effectively consolidates duplicate import statements across several files in the sdk and test-utils packages, successfully addressing the import/no-duplicates ESLint rule. The changes are clean, correct, and improve code consistency. This is a good step in the larger effort to clean up the codebase.
Summary
This PR consolidates duplicate import statements from the same modules to comply with the
import/no-duplicatesESLint rule.Part 1 of 4 - Fixes 5 files in
packages/sdkandpackages/test-utilsChanges
packages/sdk (4 files):
node:pathin test files@google/gemini-cli-coreinshell.tspackages/test-utils (1 file):
node:fsintest-rig.tsTesting
Related
packages/a2a-server(10 files)packages/core(145 files)packages/cli(207 files)