fix: merge duplicate imports in packages/core#19788
Closed
Nixxx19 wants to merge 1 commit intogoogle-gemini:mainfrom
Closed
fix: merge duplicate imports in packages/core#19788Nixxx19 wants to merge 1 commit intogoogle-gemini:mainfrom
Nixxx19 wants to merge 1 commit intogoogle-gemini:mainfrom
Conversation
Contributor
Summary of ChangesHello @Nixxx19, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refactors import statements throughout the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request aims to consolidate duplicate import statements, which is a valuable code quality improvement. While most of the changes correctly merge imports, I've identified two critical issues where the automated fix likely produced invalid TypeScript. Specifically, some value imports were incorrectly merged into import type statements, which will cause the build to fail. Please address these to ensure the code remains compilable.
Comment on lines
11
to
15
| import type { | ||
| TelemetryTarget, | ||
| AuthType, | ||
| Config, | ||
| type ConfigParameters, |
Contributor
There was a problem hiding this comment.
This change incorrectly merges the imports into an import type statement. AuthType and Config are values, not types, and cannot be imported using import type. This will cause a compilation error.
Suggested change
| import type { | |
| TelemetryTarget, | |
| AuthType, | |
| Config, | |
| type ConfigParameters, | |
| import { | |
| type TelemetryTarget, | |
| AuthType, | |
| Config, | |
| type ConfigParameters, |
Comment on lines
7
to
11
| import type { | ||
| Config, | ||
| GeminiEventType, | ||
| ApprovalMode, | ||
| type ToolCallConfirmationDetails, |
Contributor
There was a problem hiding this comment.
This change incorrectly merges the imports into an import type statement. GeminiEventType and ApprovalMode are values (likely enums), not types, and cannot be imported using import type. This will cause a compilation error.
Suggested change
| import type { | |
| Config, | |
| GeminiEventType, | |
| ApprovalMode, | |
| type ToolCallConfirmationDetails, | |
| import { | |
| type Config, | |
| GeminiEventType, | |
| ApprovalMode, | |
| type ToolCallConfirmationDetails, |
Merged duplicate import statements across all files in packages/core to comply with the import/no-duplicates ESLint rule. Changes include: - Combined type and value imports from the same module - Merged namespace imports with named imports where appropriate - Fixed import ordering to separate value imports from type imports - Ensured all imports follow the inline type import pattern All 265 test suites pass successfully. Related to google-gemini#19753
Nixxx19
force-pushed
the
nityam/cleanup-import-no-duplicates-core
branch
from
a99c450 to
070c6f5
Compare
Contributor
Author
|
Closing this PR to create a cleaner version without unrelated changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packages/core(130+ files)typesyntaximport/no-duplicatesESLint ruleChanges
--fixwithimport/no-duplicatesrule to automatically merge most duplicatesgetFolderStructure.test.tsto use correct namespace import referencesTesting
Related
Part of #19753 - PR 3 of 4 (packages/core)
Previous PRs: