fix(ui): update broken Terms of Service link in /auth (#23027)#23029
fix(ui): update broken Terms of Service link in /auth (#23027)#23029bdmorgan wants to merge 4 commits into
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses and resolves a critical issue where the Terms of Service link within the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
Size Change: -48 B (0%) Total Size: 26.2 MB
ℹ️ View Unchanged
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request fixes a broken Terms of Service link and aims to standardize documentation URLs. The changes correctly update several links to a shorter, more consistent format. However, the standardization is incomplete, as several links that follow the old pattern were not updated across multiple files. I've left specific comments pointing out the missed opportunities for standardization, referencing the rule about maintaining consistency in documentation. Completing this would improve consistency and maintainability of the documentation.
|
|
||
| - **License**: [Apache License 2.0](LICENSE) | ||
| - **Terms of Service**: [Terms & Privacy](./docs/resources/tos-privacy.md) | ||
| - **Terms of Service**: [Terms & Privacy](./docs/tos-privacy) |
There was a problem hiding this comment.
Thanks for updating the Terms of Service link. I noticed several other links in this file that could also be standardized to follow the new URL structure. For example:
- Line 285:
[**Configuration Guide**](./docs/reference/configuration.md) - Line 287:
[**Keyboard Shortcuts**](./docs/reference/keyboard-shortcuts.md) - Line 333:
[**FAQ**](./docs/resources/faq.md)
Updating these would make the link structure fully consistent with the changes in this PR.
References
- Maintain consistency in documentation. When information about a feature is present in multiple documents, ensure all instances are updated or removed together to avoid contradictions. This principle also applies to maintaining a consistent link structure within documentation.
|
|
||
| - [Gemini CLI: Quotas and Pricing](../resources/quota-and-pricing.md). | ||
| - [Gemini CLI: Terms of Service and Privacy Notice](../resources/tos-privacy.md). | ||
| - [Gemini CLI: Terms of Service and Privacy Notice](../resources/tos-privacy). |
There was a problem hiding this comment.
Thanks for updating this link. For consistency, the 'Quotas and Pricing' link on the preceding line should also be updated to remove the /resources/ path and .md extension, similar to the change you made here.
References
- Maintain consistency in documentation. When information about a feature is present in multiple documents, ensure all instances are updated or removed together to avoid contradictions. This principle also applies to maintaining a consistent link structure within documentation.
| details. | ||
| - **[Terms and privacy](./resources/tos-privacy.md):** Official notices and | ||
| terms. | ||
| - **[Terms and privacy](./tos-privacy):** Official notices and terms. |
There was a problem hiding this comment.
While you've updated the 'Terms and privacy' link, several other links in this section still use the old /resources/ path and .md extension. To complete the standardization, please update the following links as well:
[FAQ](./resources/faq.md)[Quota and pricing](./resources/quota-and-pricing.md)[Troubleshooting](./resources/troubleshooting.md)[Uninstall](./resources/uninstall.md)
This will ensure consistency across the documentation.
References
- Maintain consistency in documentation. When information about a feature is present in multiple documents, ensure all instances are updated or removed together to avoid contradictions. This principle also applies to maintaining a consistent link structure within documentation.
This commit fixes the Lychee link checker errors in the pre-submit workflow by converting several absolute repository paths that resolve to the file system root during tests to correct relative paths. Also corrects the broken 'Terms and privacy' link in index.md.
This restores absolute root-relative paths in CONTRIBUTING.md and README.md, and adds them to .lycheeignore. Because CONTRIBUTING.md is symlinked in docs/, relative paths resolve incorrectly during link checking but work on GitHub. Ignoring them prevents the false positive link check failures.
1 participant
Summary
This PR fixes the broken Terms of Service and Privacy Notice link displayed in the
/authcommand and standardizes documentation links across the codebase.Details
packages/cli/src/ui/auth/AuthDialog.tsxto use the shortened redirect URLhttps://geminicli.com/docs/tos-privacy, which resolves the reported 404 issue.packages/cli/src/ui/auth/__snapshots__/AuthDialog.test.tsx.snapto reflect the URL change.README.md,CONTRIBUTING.md,docs/index.md, and other files to use their shortened redirect paths for consistency and reliability.README.mdwith the corrected ToS link.Related Issues
Fixes #23027
How to Validate
/authcommand in the CLI.https://geminicli.com/docs/tos-privacy.README.mdanddocs/index.mdto ensure they also point to valid locations.Pre-Merge Checklist