Skip to content

fix(ui): update broken Terms of Service link in /auth (#23027) #23029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bdmorgan wants to merge 4 commits into from
Closed

fix(ui): update broken Terms of Service link in /auth (#23027) #23029

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
06c8d3a
fix(ui): update broken Terms of Service link in /auth (#23027)
bdmorgan Mar 18, 2026
debcda9
fix(docs): resolve broken links in documentation
bdmorgan Mar 19, 2026
34773fd
Merge branch 'main' into fix/tos-privacy-link
bdmorgan Mar 19, 2026
33d8d95
fix(docs): handle symlinked file in lychee link checker
bdmorgan Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .lycheeignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,6 @@ https://github.com/google-gemini/maintainers-gemini-cli/blob/main/npm.md
https://github.com/settings/personal-access-tokens/new
https://github.com/settings/tokens/new
https://www.npmjs.com/package/@google/gemini-cli
/docs/assets/connected_devtools.png
/docs/sidebar.json
/docs/assets/gemini-screenshot.png
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -557,7 +557,7 @@ Before submitting your documentation pull request, please:

If you have questions about contributing documentation:

- Check our [FAQ](https://geminicli.com/docs/resources/faq).
- Check our [FAQ](https://geminicli.com/docs/faq).
- Review existing documentation for examples.
- Open [an issue](https://github.com/google-gemini/gemini-cli/issues) to discuss
your proposed changes.
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,7 @@ instructions.
## 📄 Legal

- **License**: [Apache License 2.0](LICENSE)
- **Terms of Service**: [Terms & Privacy](./docs/resources/tos-privacy.md)
- **Terms of Service**: [Terms & Privacy](./docs/tos-privacy)
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Thanks for updating the Terms of Service link. I noticed several other links in this file that could also be standardized to follow the new URL structure. For example:

  • Line 285: [**Configuration Guide**](./docs/reference/configuration.md)
  • Line 287: [**Keyboard Shortcuts**](./docs/reference/keyboard-shortcuts.md)
  • Line 333: [**FAQ**](./docs/resources/faq.md)

Updating these would make the link structure fully consistent with the changes in this PR.

References
  1. Maintain consistency in documentation. When information about a feature is present in multiple documents, ensure all instances are updated or removed together to avoid contradictions. This principle also applies to maintaining a consistent link structure within documentation.

- **Security**: [Security Policy](SECURITY.md)

---
Expand Down
6 changes: 3 additions & 3 deletions docs/cli/telemetry.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,11 +187,11 @@ visualize your telemetry.
Find this dashboard under **Google Cloud Monitoring Dashboard Templates** as
"**Gemini CLI Monitoring**".

![Gemini CLI Monitoring Dashboard Overview](/docs/assets/monitoring-dashboard-overview.png)
![Gemini CLI Monitoring Dashboard Overview](../assets/monitoring-dashboard-overview.png)

![Gemini CLI Monitoring Dashboard Metrics](/docs/assets/monitoring-dashboard-metrics.png)
![Gemini CLI Monitoring Dashboard Metrics](../assets/monitoring-dashboard-metrics.png)

![Gemini CLI Monitoring Dashboard Logs](/docs/assets/monitoring-dashboard-logs.png)
![Gemini CLI Monitoring Dashboard Logs](../assets/monitoring-dashboard-logs.png)

To learn more, see
[Instant insights: Gemini CLI’s pre-configured monitoring dashboards](https://cloud.google.com/blog/topics/developers-practitioners/instant-insights-gemini-clis-new-pre-configured-monitoring-dashboards/).
Expand Down
2 changes: 1 addition & 1 deletion docs/get-started/authentication.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,4 +403,4 @@ Your authentication method affects your quotas, pricing, Terms of Service, and
privacy notices. Review the following pages to learn more:

- [Gemini CLI: Quotas and Pricing](../resources/quota-and-pricing.md).
- [Gemini CLI: Terms of Service and Privacy Notice](../resources/tos-privacy.md).
- [Gemini CLI: Terms of Service and Privacy Notice](../resources/tos-privacy).
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Thanks for updating this link. For consistency, the 'Quotas and Pricing' link on the preceding line should also be updated to remove the /resources/ path and .md extension, similar to the change you made here.

References
  1. Maintain consistency in documentation. When information about a feature is present in multiple documents, ensure all instances are updated or removed together to avoid contradictions. This principle also applies to maintaining a consistent link structure within documentation.

2 changes: 1 addition & 1 deletion docs/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ Support, release history, and legal information.

## Development

- **[Contribution guide](/docs/contributing):** How to contribute to Gemini CLI.
- **[Contribution guide](../CONTRIBUTING.md):** How to contribute to Gemini CLI.
- **[Integration testing](./integration-tests.md):** Running integration tests.
- **[Issue and PR automation](./issue-and-pr-automation.md):** Automation for
issues and pull requests.
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/src/config/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ export async function parseArguments(
string: true,
nargs: 1,
description:
'[DEPRECATED: Use Policy Engine instead See https://geminicli.com/docs/core/policy-engine] Tools that are allowed to run without confirmation',
'[DEPRECATED: Use Policy Engine instead See https://geminicli.com/docs/policy-engine] Tools that are allowed to run without confirmation',
coerce: coerceCommaSeparated,
})
.option('extensions', {
Expand Down
8 changes: 2 additions & 6 deletions packages/cli/src/config/settings-validation.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,9 +323,7 @@ describe('settings-validation', () => {
expect(formatted).toContain('model.name');
expect(formatted).toContain('Expected: string, but received: object');
expect(formatted).toContain('Please fix the configuration.');
expect(formatted).toContain(
'https://geminicli.com/docs/reference/configuration/',
);
expect(formatted).toContain('https://geminicli.com/docs/configuration');
}
});

Expand Down Expand Up @@ -363,9 +361,7 @@ describe('settings-validation', () => {
if (result.error) {
const formatted = formatValidationError(result.error, 'test.json');

expect(formatted).toContain(
'https://geminicli.com/docs/reference/configuration/',
);
expect(formatted).toContain('https://geminicli.com/docs/configuration');
}
});

Expand Down
2 changes: 1 addition & 1 deletion packages/cli/src/config/settings-validation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,7 @@ export function formatValidationError(
}

lines.push('Please fix the configuration.');
lines.push('See: https://geminicli.com/docs/reference/configuration/');
lines.push('See: https://geminicli.com/docs/configuration');

return lines.join('\n');
}
4 changes: 2 additions & 2 deletions packages/cli/src/gemini.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ export async function main() {
) {
coreEvents.emitFeedback(
'warning',
'Warning: --allowed-tools cli argument and tools.allowed in settings.json are deprecated and will be removed in 1.0: Migrate to Policy Engine: https://geminicli.com/docs/core/policy-engine/',
'Warning: --allowed-tools cli argument and tools.allowed in settings.json are deprecated and will be removed in 1.0: Migrate to Policy Engine: https://geminicli.com/docs/policy-engine',
);
}

Expand All @@ -249,7 +249,7 @@ export async function main() {
) {
coreEvents.emitFeedback(
'warning',
'Warning: tools.exclude in settings.json is deprecated and will be removed in 1.0. Migrate to Policy Engine: https://geminicli.com/docs/core/policy-engine/',
'Warning: tools.exclude in settings.json is deprecated and will be removed in 1.0. Migrate to Policy Engine: https://geminicli.com/docs/policy-engine',
);
}

Expand Down
2 changes: 1 addition & 1 deletion packages/cli/src/ui/auth/AuthDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ export function AuthDialog({
</Box>
<Box marginTop={1}>
<Text color={theme.text.link}>
{'https://geminicli.com/docs/resources/tos-privacy/'}
{'https://geminicli.com/docs/tos-privacy'}
</Text>
</Box>
</Box>
Expand Down
6 changes: 3 additions & 3 deletions packages/cli/src/ui/auth/__snapshots__/AuthDialog.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ exports[`AuthDialog > Snapshots > renders correctly with auth error 1`] = `
│ │
│ Terms of Services and Privacy Notice for Gemini CLI │
│ │
│ https://geminicli.com/docs/resources/tos-privacy/ │
│ https://geminicli.com/docs/tos-privacy │
│ │
╰──────────────────────────────────────────────────────────────────────────────────────────────────╯
"
Expand All @@ -34,7 +34,7 @@ exports[`AuthDialog > Snapshots > renders correctly with default props 1`] = `
│ │
│ Terms of Services and Privacy Notice for Gemini CLI │
│ │
│ https://geminicli.com/docs/resources/tos-privacy/ │
│ https://geminicli.com/docs/tos-privacy │
│ │
╰──────────────────────────────────────────────────────────────────────────────────────────────────╯
"
Expand All @@ -53,7 +53,7 @@ exports[`AuthDialog > Snapshots > renders correctly with enforced auth type 1`]
│ │
│ Terms of Services and Privacy Notice for Gemini CLI │
│ │
│ https://geminicli.com/docs/resources/tos-privacy/ │
│ https://geminicli.com/docs/tos-privacy │
│ │
╰──────────────────────────────────────────────────────────────────────────────────────────────────╯
"
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/src/ui/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ export const DEFAULT_SELECTION_OPACITY = 0.2;
export const DEFAULT_BORDER_OPACITY = 0.4;

export const KEYBOARD_SHORTCUTS_URL =
'https://geminicli.com/docs/cli/keyboard-shortcuts/';
'https://geminicli.com/docs/keyboard-shortcuts';
export const LRU_BUFFER_PERF_CACHE_LIMIT = 20000;

// Max lines to show for active shell output when not focused
Expand Down
2 changes: 1 addition & 1 deletion packages/vscode-ide-companion/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,4 +31,4 @@ To use this extension, you'll need:
# Terms of Service and Privacy Notice

By installing this extension, you agree to the
[Terms of Service](https://geminicli.com/docs/resources/tos-privacy/).
[Terms of Service](https://geminicli.com/docs/tos-privacy).
Loading