chore: Introduce a parent POM #155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
shukladivyansh
left a comment
shukladivyansh
left a comment
There was a problem hiding this comment.
I remember @Poggecci was running into some issue previously when trying to unify the poms. Maybe we would want to check for those.
This was referenced Jun 6, 2025
Poggecci
approved these changes
Jun 16, 2025
Contributor
Poggecci
left a comment
Poggecci
left a comment
There was a problem hiding this comment.
Approved contingent on fixing the merge conflicts.
* main: (29 commits) Simplify creation of Gemini instances. Refactor BaseLlmFlow `preprocess` and `postprocess` to no longer use blocking calls. ADK changes Remove wrong auto-value dependency to fix confusing annotation processing related message from Maven, see google#172. Add missing .gitignore with Maven target/ Fix bug in listing events for empty list of sessions Fix broken JavaDoc in InstructionUtils. (Fix): Empty check instead of null check for `Part`'s inline data. chore: Fixing the "appendEvent" test in VertexAISessionServiceTests. Fixing the test also led to fixing some parsing bugs in VertexAISessionService. chore: update adk-web to use latest Persist session into memory after each appendEvent(). Fix a bug in SessionUtils that filtered out all previous events in chats for Vertex stored sessions. fix: hide new eval metric behind flag feat: save and last run threshold and use it in next run evaluation chore: Fix wrong Maven version numbers docs: Clarify Compatibility Guarantees in contrib's README feat: show the used metric in evaluation history Refactor `preprocess` in `BaseLlmFlow` to return a `Single`. feat: use threshold from the eval config dialog to run eval feat: Expose branch as part of ReadonlyContext. ...
Member
Author
@Poggecci conflicts now resolved; merge? |
* main: chore: Use fixed Maven version (via Wrapper) in GitHub Validation Workflow (CI) chore: Add Maven ./mvnw wrapper to fix version and avoid having to separately download it
Poggecci
approved these changes
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.