Integration with LangChain4j to support third-party and local models #102

glaforge · 2025-05-23T16:36:05Z

This is an experimental integration with LangChain4j, to show that it's possible to open up ADK to all the models supported by the LangChain4j framework, and also Ollama or Docker Model Runner exposed models via LangChain4j.

cornellgit · 2025-05-24T03:30:17Z

This is awesome, created a contrib/ folder, we can put it there first then gradually iterate.

glaforge · 2025-05-24T17:24:41Z

@cornellgit Good idea, my contribution will make more sense in a contrib folder! 😉

Moved this code into the new contrib directory

glaforge · 2025-05-26T14:41:21Z

@cornellgit Moved my WIP experiment in the new contrib directory.
Haven't touched yet the implementation itself, there's still a fair bit of work to cover most tools for examples.
Once/if we want to release the contribution, we'll have to review the pom.xml to ensure this can be pushed to Maven Central at some point.

Accidently moved the model class in the test directory

contrib/pom.xml

contrib/src/main/java/com/google/adk/models/langchain4j/LangChain4j.java

contrib/langchain4j/src/test/java/com/google/adk/models/langchain4j/LangChain4jTest.java

vorburger · 2025-05-31T20:44:07Z

core/pom.xml

    <java-websocket.version>1.6.0</java-websocket.version>
    <jackson.version>2.19.0</jackson.version>
    <okhttp.version>4.12.0</okhttp.version>
+    <langchain4j.version>1.0.1</langchain4j.version>


This wouldn't go here... witht the contrib/langchain4j "module" it (now) belongs in that POM, agreed?

Maybe it's easier to wait for #155, first; up to you.

@glaforge remove this?

@glaforge sorry not remove, of course, but move from here (core) into the contrib/langchain/pom.xml would be "cleaner", no?

Should it be in core if it's specific to that module?

Given that the langchain4j.version is specific (only) to the contrib/langchain4j/pom.xml, IMHO this "belongs" there (but it's currently in core/pom.xml where IMHO it shouldn't be).

Oh yes, you're right!

contrib/langchain4j/src/test/java/com/google/adk/models/langchain4j/LangChain4jTest.java

(Anthropic doesn't set it, but OpenAI seems to set it)

contrib/langchain4j/src/main/java/com/google/adk/models/langchain4j/LangChain4j.java

contrib/langchain4j/src/test/java/com/google/adk/models/langchain4j/LangChain4jTest.java

Add Ollama in test scope to test local models running with Ollama

contrib/langchain4j/src/main/java/com/google/adk/models/langchain4j/LangChain4j.java

Use `@EnabledIfEnvironmentVariable` to conditionally skip tests

Add unit test

…own class, externalized tool function to avoid reflection issues

vorburger · 2025-06-17T16:30:09Z

@glaforge now that #155 got (just) merged, do you want to rebase this, to use it? I'd be happy to then re-review it.

Then, if you would like to get this as-is, perhaps undraft it?

glaforge · 2025-06-17T21:50:17Z

Thanks for the heads up! Good news!
I'll try to look into it tomorrow!

glaforge · 2025-06-18T12:18:27Z

Rebased with the parent pom.xml

contrib/langchain4j/pom.xml

vorburger · 2025-06-18T13:27:28Z

contrib/langchain4j/pom.xml

+ limitations under the License.
+-->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"


With #155, you could remove a lot more here... if you like - note how both the core/pom.xml and the dev/pom.xml are [much] shorter, now. But it's not very important, if you prefer leaving this as-is, we (me) could also just do this in a later follow-up PR.

I went with the simplest thing, but I was wondering what should be moved back to the parent, etc.
If you have a concrete suggestion, I'm happy to apply it!

@glaforge in the interest of not holding this up any further, let's leave it as-is for now, and see if maintainers agree to merge as-is. I'll follow up with a "POM clean up" sort of PR later, once this is merged.

vorburger

LGTM, as an initial version.

Suggest that we merge this as-is, and then incrementally improve as needed.

vorburger · 2025-06-18T15:00:49Z

contrib/langchain4j/pom.xml

+ limitations under the License.
+-->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"


@glaforge in the interest of not holding this up any further, let's leave it as-is for now, and see if maintainers agree to merge as-is. I'll follow up with a "POM clean up" sort of PR later, once this is merged.

Poggecci

Need to check in a change to our Copybara before this can get merged in

geragaelms-arch

Muy bueno

[WIP] Proof of Concept integration with LangChain4j

ea9223c

cornellgit mentioned this pull request May 24, 2025

Feature request: Supports OpenAI compatible model #100

Open

Merge branch 'google:main' into main

7381f1e

glaforge added 2 commits May 25, 2025 19:19

Merge branch 'google:main' into main

7cd6dc0

[WIP] Proof of Concept integration with LangChain4j

d705754

Moved this code into the new contrib directory

glaforge added 2 commits May 26, 2025 16:52

[WIP] Proof of Concept integration with LangChain4j

0f265a5

Accidently moved the model class in the test directory

[WIP] Cover other types of tools

2b5707e

vorburger reviewed May 31, 2025

View reviewed changes

contrib/pom.xml Show resolved Hide resolved

vorburger reviewed May 31, 2025

View reviewed changes

contrib/src/main/java/com/google/adk/models/langchain4j/LangChain4j.java Outdated Show resolved Hide resolved

glaforge added 2 commits May 31, 2025 21:03

[WIP] Move the LangChain4j integration in its own subdirectory.

ca16869

Merge branch 'google:main' into main

b0ab694

vorburger requested changes May 31, 2025

View reviewed changes

glaforge added 7 commits May 31, 2025 23:49

[WIP] Further hyperparameter handling and function calling mode

de547a0

[WIP] Not all LangChain4j models set their model name as default values

390102f

(Anthropic doesn't set it, but OpenAI seems to set it)

[WIP] Adding a test case for sub-agents

6dbe175

Merge branch 'google:main' into main

4a444d9

[WIP] Streaming model support

b1b3250

Merge branch 'google:main' into main

0bde593

[WIP] Making function calling work in streaming mode

6b100c7

vorburger mentioned this pull request Jun 6, 2025

docs: Clarify Compatibility Guarantees in contrib's README #167

Merged

vorburger reviewed Jun 6, 2025

View reviewed changes

contrib/langchain4j/src/main/java/com/google/adk/models/langchain4j/LangChain4j.java Show resolved Hide resolved

vorburger reviewed Jun 6, 2025

View reviewed changes

contrib/langchain4j/src/test/java/com/google/adk/models/langchain4j/LangChain4jTest.java Show resolved Hide resolved

glaforge added 3 commits June 6, 2025 19:41

Merge branch 'google:main' into main

adfba35

[WIP] Add ASL header in test class

47e8795

Add Ollama in test scope to test local models running with Ollama

[WIP] Add LangChain4j's @experimental annotation

defb4de

This was referenced Jun 6, 2025

Support continously deployed SNAPSHOTs (either from JitPack, or with CI/CD to another Maven repo) #173

Closed

LangChain4j LLM Adapter: Support StreamingChatModel #175

Closed

vorburger reviewed Jun 7, 2025

View reviewed changes

contrib/langchain4j/src/main/java/com/google/adk/models/langchain4j/LangChain4j.java Outdated Show resolved Hide resolved

kpavlov and others added 7 commits June 9, 2025 21:32

Cleanup pom

ab7ecf4

Add unit test

7986107

Run integration test conditionally

29f8bd0

Use `@EnabledIfEnvironmentVariable` to conditionally skip tests

Merge pull request #1 from kpavlov/main

cc885a0

Add unit test

Merge branch 'google:main' into main

6eb39a8

Merge branch 'google:main' into main

9673f20

[WIP] Improve support for multiple modalities, moved run loop in its …

6010793

…own class, externalized tool function to avoid reflection issues

glaforge added 2 commits June 18, 2025 13:49

Merge branch 'google:main' into main

1409047

[WIP] Depend on parent pom.xml

7ac470c

glaforge changed the title ~~[WIP] Proof of Concept integration with LangChain4j~~ Integration with LangChain4j to support third-party and local models Jun 18, 2025

glaforge marked this pull request as ready for review June 18, 2025 12:18

[WIP] Don't use the demo key for OpenAI

069ea36

vorburger reviewed Jun 18, 2025

View reviewed changes

contrib/langchain4j/pom.xml Outdated Show resolved Hide resolved

vorburger reviewed Jun 18, 2025

View reviewed changes

contrib/langchain4j/pom.xml Outdated Show resolved Hide resolved

vorburger reviewed Jun 18, 2025

View reviewed changes

vorburger approved these changes Jun 18, 2025

View reviewed changes

glaforge added 2 commits June 18, 2025 17:14

[WIP] Use ${project.version} in pom.xml

85f52ef

[WIP] Removing langchain4j mention from core

6aeb27e

Poggecci approved these changes Jun 18, 2025

View reviewed changes

Poggecci added the ready to pull label Jun 18, 2025

copybara-service bot merged commit 0d1bb89 into google:main Jun 18, 2025
5 checks passed

vorburger mentioned this pull request Jun 19, 2025

clean: Simplify contrib/langchain4j/pom.xml #206

Merged

geragaelms-arch reviewed Aug 1, 2025

View reviewed changes

geragaelms-arch approved these changes Aug 1, 2025

View reviewed changes

Integration with LangChain4j to support third-party and local models #102

Integration with LangChain4j to support third-party and local models #102

Uh oh!

Conversation

glaforge commented May 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cornellgit commented May 24, 2025

Uh oh!

glaforge commented May 24, 2025

Uh oh!

glaforge commented May 26, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vorburger commented Jun 17, 2025

Uh oh!

glaforge commented Jun 17, 2025

Uh oh!

glaforge commented Jun 18, 2025

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vorburger left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Poggecci left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

geragaelms-arch left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

glaforge commented May 23, 2025 •

edited

Loading