chore: Pin all minitest versions to 5.11.x #4116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Member
|
Running ci locally for this branch. |
quartzmo
added a commit
to quartzmo/google-cloud-ruby
that referenced
this pull request
Apr 17, 2020
quartzmo
added a commit
to quartzmo/google-cloud-ruby
that referenced
this pull request
Apr 20, 2020
quartzmo
added a commit
to quartzmo/google-cloud-ruby
that referenced
this pull request
Apr 21, 2020
quartzmo
added a commit
to quartzmo/google-cloud-ruby
that referenced
this pull request
Apr 21, 2020
quartzmo
added a commit
to quartzmo/google-cloud-ruby
that referenced
this pull request
Apr 22, 2020
quartzmo
added a commit
that referenced
this pull request
Apr 22, 2020
* Add rubocop-minitest * Run bundle exec rubocop --only Minitest/GlobalExpectations -a * Revert rubocop-minitest * Manually fix unit test errors * Remove deprecated Concurrent.disable_at_exit_handlers! from acceptance test helper.rb since it now has no effect, see ruby-concurrency/concurrent-ruby#841 refs: #4110 refs: #4116 pr: #5654
quartzmo
added a commit
to quartzmo/google-cloud-ruby
that referenced
this pull request
Apr 23, 2020
quartzmo
added a commit
that referenced
this pull request
Apr 23, 2020
* Add rubocop-minitest * Run bundle exec rubocop --only Minitest/GlobalExpectations -a * 127 files inspected, 1349 offenses detected, 1349 offenses corrected * Revert rubocop-minitest * Manually fix broken expectations in test stubs * Manually fix broken raises expectations in unit tests * Manually fix broken raises expectations in acceptance tests refs: #4110 refs: #4116 pr: #5688
quartzmo
added a commit
to quartzmo/google-cloud-ruby
that referenced
this pull request
Apr 24, 2020
quartzmo
added a commit
to quartzmo/google-cloud-ruby
that referenced
this pull request
Apr 24, 2020
quartzmo
added a commit
to quartzmo/google-cloud-ruby
that referenced
this pull request
Apr 27, 2020
quartzmo
added a commit
to quartzmo/google-cloud-ruby
that referenced
this pull request
Apr 27, 2020
quartzmo
added a commit
to quartzmo/google-cloud-ruby
that referenced
this pull request
Apr 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pin minitest to
5.11.xin all Gemfiles not covered by #4115