Skip to content

Conversation

@quartzmo
Copy link
Member

Use rubocop-minitest gem and bundle exec rubocop --only Minitest/GlobalExpectations -a to autocorrect minitest warnings for Ruby 2.7.

refs: #4110
refs: #4116

@quartzmo quartzmo self-assigned this Apr 24, 2020
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 24, 2020
@quartzmo quartzmo requested a review from a team April 24, 2020 15:49
@quartzmo quartzmo added the api: dns Issues related to the Cloud DNS API. label Apr 24, 2020
Copy link
Contributor

@dazuma dazuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The test failure is the link checker, which is active again. I'm kicking that can one more time #5694

@quartzmo quartzmo merged commit b1d32fe into googleapis:master Apr 24, 2020
@quartzmo quartzmo deleted the dns-minitest-update branch April 24, 2020 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: dns Issues related to the Cloud DNS API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants