Skip to content

gha-cd: allow workflow_dispatch#73

Merged
bpdohall merged 1 commit intoteleportfrom
brendan/allow-workflow-dispatch-for-release
Mar 11, 2025
Merged

gha-cd: allow workflow_dispatch#73
bpdohall merged 1 commit intoteleportfrom
brendan/allow-workflow-dispatch-for-release

Conversation

@bpdohall
Copy link
Collaborator

Lets us trigger the CD workflow with a custom tag name.

Extends the tag filter to include tagged releases. I don't expect those will get a clean tag.

TAG ?= $(shell git describe --tags --dirty --always)
RELEASE_VERSION ?= ${TAG}
CHART_VERSION ?= ${RELEASE_VERSION}

@bpdohall bpdohall self-assigned this Mar 11, 2025
on:
push:
tags:
- 'v[0-9]+.[0-9]+.[0-9]+.*'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a valid regexp? 🤔

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's why the previous value didn't work -- it's a glob (ref):

The branches, branches-ignore, tags, and tags-ignore keywords accept glob patterns that use characters like *, **, +, ?, ! and others to match more than one branch or tag name. If a name contains any of these characters and you want a literal match, you need to escape each of these special characters with . For more information about glob patterns, see the Workflow syntax for GitHub Actions.

https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet

A dot is a literal dot.

@bpdohall bpdohall merged commit 7b58afc into teleport Mar 11, 2025
6 checks passed
logand22 pushed a commit that referenced this pull request Aug 5, 2025
logand22 pushed a commit that referenced this pull request Sep 8, 2025
logand22 pushed a commit that referenced this pull request Sep 30, 2025
logand22 pushed a commit that referenced this pull request Sep 30, 2025
logand22 pushed a commit that referenced this pull request Oct 2, 2025
logand22 pushed a commit that referenced this pull request Oct 7, 2025
logand22 pushed a commit that referenced this pull request Oct 27, 2025
logand22 pushed a commit that referenced this pull request Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants