Skip to content

gha-cd: allow workflow_dispatch #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bpdohall merged 1 commit into from
Mar 11, 2025
Merged

gha-cd: allow workflow_dispatch #73

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .github/workflows/cd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,15 @@ name: cd
on:
push:
tags:
- 'v[0-9]+.[0-9]+.[0-9]+.*'
Copy link

@taraspos taraspos Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a valid regexp? 🤔

Copy link
Collaborator Author

@bpdohall bpdohall Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's why the previous value didn't work -- it's a glob (ref):

The branches, branches-ignore, tags, and tags-ignore keywords accept glob patterns that use characters like *, **, +, ?, ! and others to match more than one branch or tag name. If a name contains any of these characters and you want a literal match, you need to escape each of these special characters with . For more information about glob patterns, see the Workflow syntax for GitHub Actions.

https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet

A dot is a literal dot.

- 'v[0-9]+.[0-9]+.[0-9]+-*'
branches:
- teleport
workflow_dispatch:
inputs:
image_tag:
description: Tag for image and helm chart
required: true
type: string

permissions:
contents: read
Expand All @@ -20,6 +26,7 @@ jobs:
env:
AWS_REGION: us-east-1
ECR_AWS_ROLE: arn:aws:iam::146628656107:role/envoy-gateway-github-action-ecr-role
RELEASE_VERSION: ${{ inputs.image_tag }}
runs-on: ubuntu-latest
needs: [verify, test]
steps:
Expand Down
Loading