Fixed #17394 - Changes the acceptance letter salutation to target#17436
Merged
snipe merged 4 commits intogrokability:developfrom Jul 23, 2025
Merged
Fixed #17394 - Changes the acceptance letter salutation to target#17436snipe merged 4 commits intogrokability:developfrom
snipe merged 4 commits intogrokability:developfrom
Conversation
snipe
changed the title
snipe
changed the title
Member
in the tests |
snipe
requested changes
Jul 22, 2025
Member
snipe
left a comment
snipe
left a comment
There was a problem hiding this comment.
Still seeing some failing tests here
Member
|
I think that will create a scenario where we have |
Member
Author
|
Member
Author
|
some failing tests, checking it out |
Member
Author
|
I removed the intro line by accident, tests pass now. |
36864
reviewed
Jul 24, 2025
Comment on lines
+2
to
+4
| @php | ||
| $target->assignedto = null; | ||
| @endphp |
Contributor
There was a problem hiding this comment.
Was this leftover from debugging?
Member
There was a problem hiding this comment.
I think that was already removed tho? I don't see it in that blade anymore
Member
There was a problem hiding this comment.
Derp. Helps if you're up to date locally :P I'll remove it tho
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the salutation target to
$target->assignedtoin the accessories and asset checkout mail markdowns.Fixes: #17394