Skip to content

Fixed #17394 - Changes the acceptance letter salutation to target #17436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
snipe merged 4 commits into from
Jul 23, 2025
Merged

Fixed #17394 - Changes the acceptance letter salutation to target #17436

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
49da9e5
changed markdown to point to assignedto name
Godmartinz Jul 21, 2025
a624a79
add terenary
Godmartinz Jul 22, 2025
440e969
remove unnecessary spacing
Godmartinz Jul 23, 2025
b670b20
accidentally removed a line
Godmartinz Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion resources/views/mail/markdown/checkout-accessory.blade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@component('mail::message')
# {{ trans('mail.hello') }} {{ $target->present()->fullName() }},
# {{ trans('mail.hello') }}{{ $target->assignedto?->present()->fullName() ? ' ' . $target->assignedto->present()->fullName() . ',' : ',' }}

{{ trans('mail.new_item_checked') }}

Expand Down
7 changes: 5 additions & 2 deletions resources/views/mail/markdown/checkout-asset.blade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
@component('mail::message')
# {{ trans('mail.hello') }} {{ $target->present()->fullName() }},
@php
$target->assignedto = null;
@endphp
Comment on lines +2 to +4
Copy link
Copy Markdown
Contributor

@36864 36864 Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this leftover from debugging?

Copy link
Copy Markdown
Member

@snipe snipe Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oooh, good catch

Copy link
Copy Markdown
Member

@snipe snipe Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that was already removed tho? I don't see it in that blade anymore

Copy link
Copy Markdown
Member

@snipe snipe Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Derp. Helps if you're up to date locally :P I'll remove it tho

# {{ trans('mail.hello') }}{{ $target->assignedto?->present()->fullName() ? ' ' . $target->assignedto->present()->fullName() . ',' : ',' }}

{{ $introduction_line }}
{{ $introduction_line }}

@if (($snipeSettings->show_images_in_email =='1') && $item->getImageUrl())
<center><img src="{{ $item->getImageUrl() }}" alt="Asset" style="max-width: 570px;"></center>
Expand Down
Loading