Possible fix for #17808 - RTL in pdf files for acceptances #17817
Closed
Possible fix for #17808 - RTL in pdf files for acceptances #17817
Conversation
Signed-off-by: snipe <snipe@snipe.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The longer conversation around this is here: #17808
I hate just about everything about this PR, but of the options I've tried, this one seems to handle all of the scenarios. This is still very much a WIP, as I need to refactor the PDF handling so that we're not repeating ourselves for each potential acceptance PDF, but this does mostly seem to work.