Fixed #14744 and #17808 - Added CJK and Arabic font support for asset acceptance#17866
Merged
Fixed #14744 and #17808 - Added CJK and Arabic font support for asset acceptance#17866
Conversation
Member
Author
|
This seems ready to go, but in my regular tests, I'm not seeing a checkout notification go out to the user when acceptance isn't required. I don't think that's related, but not sure yet. |
Member
Author
|
I'll fix the labels in a different PR I think |
Merged
This was referenced Oct 27, 2025
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a rework of my first attempt (rebase was messy so I just started again). Right now only the acceptance PDFs are generated, but I'm going to see if I can use these new detection methods in the labels as well.
As mentioned in some of the other issues, this was particularly tricky since the user in question had mixed English and Arabic, which domPDF just does not handle properly.
The end result is that instead of using the acceptance HTML template, we have to manually create the PDF in the controller itself, which I mostly hate, but I don't see another way around it.
Example text:
Rework of #17817 and #14235
Fixes #14744 and #17808