Skip to content

Fixed #17585 - Display accessory checkout qty in subject line and intro text#17826

Merged
snipe merged 3 commits intogrokability:developfrom
marcusmoore:fixes/17585-accessory-checkout-amount-in-subject
Sep 11, 2025
Merged

Fixed #17585 - Display accessory checkout qty in subject line and intro text#17826
snipe merged 3 commits intogrokability:developfrom
marcusmoore:fixes/17585-accessory-checkout-amount-in-subject

Conversation

@marcusmoore
Copy link
Copy Markdown
Collaborator

@marcusmoore marcusmoore commented Sep 8, 2025

Subject line is now plural for accessory checkouts that have qty greater than 1.

Singular Multiple
image image

Currently, in both instances the introduction text says "A new item has been checked out under your name". That should be updated as well but that touches a lot more translation strings than the one already changed and I don't want to trigger new translations if we don't need to.

  • @snipe should I address the intro text as well?
    • Added

Fixes #17585

@snipe
Copy link
Copy Markdown
Member

snipe commented Sep 10, 2025

I'm okay with triggering new translations if it makes it more clear.

@marcusmoore
Copy link
Copy Markdown
Collaborator Author

@snipe updated with totals in the introduction text. The screenshots in the original description are now accurate.

@marcusmoore marcusmoore changed the title Fixed #17585 - Display accessory checkout qty in subject line Fixed #17585 - Display accessory checkout qty in subject line and intro text Sep 11, 2025
@snipe snipe merged commit b2406b6 into grokability:develop Sep 11, 2025
4 of 7 checks passed
@marcusmoore marcusmoore deleted the fixes/17585-accessory-checkout-amount-in-subject branch September 11, 2025 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Display pluralized amount of accessories checked out in subject line of email

2 participants